Skip to content

Conversation

@jlopp
Copy link
Contributor

@jlopp jlopp commented Mar 26, 2017

As far as I can tell, "noconnect" is never actually parsed as an argument in the codebase.

@fanquake fanquake added the Docs label Mar 26, 2017
@luke-jr
Copy link
Member

luke-jr commented Mar 26, 2017

-no* is the same as -*=0

@jlopp
Copy link
Contributor Author

jlopp commented Mar 26, 2017

@luke-jr can you point out where the logic is that translates a "no*" parameter into a "*=0" parameter?

@maflcko
Copy link
Member

maflcko commented Mar 26, 2017 via email

@jlopp
Copy link
Contributor Author

jlopp commented Mar 26, 2017

Aha; thanks for the clarification.

@jlopp jlopp closed this Mar 26, 2017
@sipa
Copy link
Member

sipa commented Mar 26, 2017

@jlopp If it wasn't clear that -noX is an alias for -X=0, perhaps that should be documented more clearly in the -help output?

@maflcko
Copy link
Member

maflcko commented Mar 26, 2017 via email

@jlopp
Copy link
Contributor Author

jlopp commented Mar 26, 2017

@sipa Yes, possibly - I'll think about it. I'm currently working on a project involving Bitcoin Core's configuration options, which is why I'm currently exploring this area of the codebase.

@sipa
Copy link
Member

sipa commented Mar 26, 2017

@jlopp, regardless, I agree with @MarcoFalke that this PR probably improves things, despite not fixing anything technically incorrect. I suggest reopening.

@jlopp
Copy link
Contributor Author

jlopp commented Mar 26, 2017

Sure, done.

@jlopp jlopp reopened this Mar 26, 2017
@laanwj
Copy link
Member

laanwj commented Mar 27, 2017

-noconnect works fine and I use it a lot for internal tests. It's a little bit more consistent to not mention it explicitly in the help I guess but please don't say that things don't work if they do!

@laanwj laanwj merged commit d5690f1 into bitcoin:master Mar 27, 2017
laanwj added a commit that referenced this pull request Mar 27, 2017
d5690f1 remove 'noconnect' option from documentation (Jameson Lopp)

Tree-SHA512: 9c61df5ee7b2b9a8188cbf44fced05c41ded3454758dbc1b1ae641cea0301a65169381f20c045027e571ebe211a42e680a66daed47090f91766403cc60147e89
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request May 21, 2019
d5690f1 remove 'noconnect' option from documentation (Jameson Lopp)

Tree-SHA512: 9c61df5ee7b2b9a8188cbf44fced05c41ded3454758dbc1b1ae641cea0301a65169381f20c045027e571ebe211a42e680a66daed47090f91766403cc60147e89
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants