Auto-remove logs, and decrease logfile size to 10M #1007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ACK |
1 similar comment
Member
|
ACK |
gavinandresen
added a commit
that referenced
this pull request
Mar 29, 2012
Auto-remove logs, and decrease logfile size to 10M
coblee
referenced
this pull request
in litecoin-project/litecoin
Jul 17, 2012
Auto-remove logs, and decrease logfile size to 10M
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
ptschip
pushed a commit
to ptschip/bitcoin
that referenced
this pull request
Apr 5, 2018
[Phase2] Use shared txn pointers for XTHIN processing
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Oct 30, 2019
8a0048f Show current version on splash screen (Fuzzbawls) 6e36259 Resize splash and use background-image (Fuzzbawls) abd5e8c [Qt] Reintroduce networkstyle to title texts (Fuzzbawls) Pull request description: Allows for the window's title to contain `[testnet]` or `[regtest]` as needed. Also makes the splash screen a full window. window with 96b4e09:  window with 4bfb2f6:  ACKs for top commit: furszy: ACK [`8a0048f`](PIVX-Project@8a0048f) Warrows: ACK 8a0048f random-zebra: ACK 8a0048f and merging... Tree-SHA512: 17ffe67941ed303db91886b83c5c1140b701fd37ee45f6ceba81ff07c774a3c96c8b5926ec9da55c837f06a4c040bfc2a99b05804ff582ffd5953bbf9f0e375f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to pull #1004 , to fix part of bug #999
Tested by doing a complete blockchain download and observing the number of log files every 2 minutes (see https://gist.github.com/2236954 -- maximum of 5 were created).
Removing log files before shutdown does make 'catastrophic database recovery' impossible, however catastrophic recovery is only possible if you have ALL of the log files available (all since the creation of the database), so the only situation in which that is an issue would be a brand-new user running Bitcoin for the first time and then suffering a disk-corrupting failure before they shutdown.