[trivial] Fixed -Wshadow warnings #10009
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjps
changed the title
| ~MemoryCheck(){ | ||
| fake_allocated_memory -= b; | ||
|
|
Contributor
There was a problem hiding this comment.
Intentional blank line? :-)
laanwj
reviewed
Mar 16, 2017
|
|
||
| template<typename... Args> | ||
| bool error(const char* fmt, const Args&... args) | ||
| bool error(const char* fmt, Args... args) |
Member
There was a problem hiding this comment.
Not sure what you're doing here but I doubt it is required to "Fix Wshadow".
Member
|
Also may be duplicate of #9911. |
Member
|
Closing in favor of #10010 which is cleaner and more targeted. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.