Skip to content

setup.nsi.in has "bitcoin" and "Bitcoin Core" hardcoded a lot #7265

@JeremyRand

Description

@JeremyRand

https://github.com/bitcoin/bitcoin/blob/master/share/setup.nsi.in has the strings "bitcoin" and "Bitcoin Core" hardcoded in many places, even though those strings are available via autoconf. This makes it slightly more bothersome to change the name of the project, because changing the AC_INIT line in configure.ac isn't sufficient.

I don't know if this is something you want to fix in your repo, since it mostly only affects downstream projects like Namecoin. If you are interested in fixing this, I'd be happy to submit a PR.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions