Skip to content

torcontrol is noisy in debug.log if no Tor running #7032

@laanwj

Description

@laanwj

E.g.

2015-11-16 15:18:25 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
2015-11-16 15:18:26 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
2015-11-16 15:18:27 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
2015-11-16 15:18:30 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
2015-11-16 15:18:33 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
2015-11-16 15:18:38 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
2015-11-16 15:18:46 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
2015-11-16 15:18:57 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
2015-11-16 15:19:14 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
2015-11-16 15:19:40 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
2015-11-16 15:20:19 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
2015-11-16 15:21:16 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
2015-11-16 15:22:43 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect

Keeping trying to connect makes sense, as the user may (re)start Tor later. The exponential back-off is also clearly working.
However, it shouldn't be logging this all the time (possibly only with -debug=tor), and a "disconnected" message is wrong if it cannot even connect.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions