Skip to content

Proxy support broken when onlynet=tor is set, causing connection leak. #5355

@gmaxwell

Description

@gmaxwell

On git master setting -proxy= on a host which is -onlynet=tor no longer sets the generic proxy for v4/v6 at all.

As a result getinfo is incorrect, as a cosmetic bug the harm would mostly be causing users an undeserved heart attack... but it's not entirely undeserved:

This makes the payment protocol connections leak, since they interograte OptionsModel::getProxySettings() which runs GetProxy(NET_IPV4, curProxy).

I believe that proxy should set the proxy for all networks, even limited ones. I don't understand why it ever didn't thus the issue instead of a patch.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions