Skip to content

Remove bolt-on accounting system #3816

@jgarzik

Description

@jgarzik

The recent malleability issues exposed some cases not covered by the accounting system. Rather than fix it, the consensus seems to lean towards scrapping the accounting system entirely, and returning to a system where keys may have labels (or tags, as I prefer to call them).

The accounting system can easily result in negative or odd balances if misused or misunderstood, which has happened in the field. Use of raw tx API or direct spends exacerbates this. Users are used to seemingly-odd practices of transferring imaginary money from a dummy account, to eliminate a negative number in some cases.

Practically speaking, this seems likely to be a large, incompatible change to RPC. This implies

  • other incompatible RPC changes are possible
  • the following line in rpcserver.cpp should be updated along standard REST API versioning conventions, changing the standard URI path from "/" to "/v2/" or somesuch.
        if (strURI != "/") {

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions