Skip to content

bench: broken CSV format, commas in benchmark names #33331

@Raimo33

Description

@Raimo33

Currently there are a couple of benchmarks that have commas in their name:

  • SHA256D64_1024_AVX2 using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation
  • SHA256D64_1024_SHANI using the 'sse4(1way),sse41(4way)' SHA256 implementation
  • SHA256D64_1024_SSE4 using the 'sse4(1way),sse41(4way)' SHA256 implementation
  • SHA256D64_1024_STANDARD using the 'standard' SHA256 implementation
  • SHA256_32b_AVX2 using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation
  • SHA256_32b_SHANI using the 'sse4(1way),sse41(4way)' SHA256 implementation
  • SHA256_32b_SSE4 using the 'sse4(1way),sse41(4way)' SHA256 implementation
  • SHA256_32b_STANDARD using the 'standard' SHA256 implementation
  • SHA256_AVX2 using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation
  • SHA256_SHANI using the 'sse4(1way),sse41(4way)' SHA256 implementation
  • SHA256_SSE4 using the 'sse4(1way),sse41(4way)' SHA256 implementation
  • SHA256_STANDARD using the 'standard' SHA256 implementation

This breaks the CSV format when using ./bench_bitcoin -output-csv=bench_old.csv. Commas are allowed only as column separators in CSV.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions