Skip to content

remove create_child_with_parents, make_chain, and create_raw_chain from test_framework/wallet #25965

@glozow

Description

@glozow

These 3 functions create packages of transactions without broadcasting:

def make_chain(node, address, privkeys, parent_txid, parent_value, n=0, parent_locking_script=None, fee=DEFAULT_FEE):

They were introduced in #20833 and #21800 to avoid using the wallet in non-wallet functional tests.

Since then, wonderful people have created the same functionality in MiniWallet, so these are now redundant. I'm rewriting my branches to avoid using them. It would be a good cleanup to (1) refactor the call sites in rpc_packages.py to use MiniWallet instead, and (2) remove these 3 functions from wallet.py.

This is very similar to #20078.

Useful skills:

  • Familiarity with our functional test suite
  • Good python3 skills

Want to work on this issue?

For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions