Skip to content

revert protocol change (feefilter now ignored) #21839

@rebroad

Description

@rebroad

#19260 was merged, which now causes older nodes to not receive TXs when they ask for them. the feefilter message was established as a way for nodes to request TXs after IBD. It was not only used for bloom filters.

There's no benefit in having it disabled, and it breaks things by disabling it as it risks older nodes not receiving TXs from newer nodes.

It was claimed in #19260 that feefilters are a better way to block TXs from being sent, but this seem to go on the assumption that all nodes are running the feefilter logic, which old nodes would not be.

So perhaps this raises the question - should we be forcing people to update their node software, or should we be trying to ensure that older nodes are respected?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions