Skip to content

gui: Avoid calling processEvents #16875

@promag

Description

@promag

Got the following stack trace while debugging #15204:

  * frame #0: 0x00000001000e9ce6 bitcoin-qt`OpenExternalWalletActivity::finish(this=0x000000010e9023e0) at walletcontroller.cpp:303 [opt]
    frame #1: 0x0000000101f6b34d QtCore`___lldb_unnamed_symbol2532$$QtCore + 173
    frame #2: 0x0000000101f5b756 QtCore`QObject::event(QEvent*) + 102
    frame #3: 0x000000010128746d QtWidgets`QApplicationPrivate::notify_helper(QObject*, QEvent*) + 269
    frame #4: 0x0000000101288897 QtWidgets`QApplication::notify(QObject*, QEvent*) + 583
    frame #5: 0x0000000101f31f64 QtCore`QCoreApplication::notifyInternal2(QObject*, QEvent*) + 164
    frame #6: 0x0000000101f89724 QtCore`QTimerInfoList::activateTimers() + 996
    frame #7: 0x000000010343732f libqcocoa.dylib`___lldb_unnamed_symbol548$$libqcocoa.dylib + 2351
    frame #8: 0x0000000101f32437 QtCore`QCoreApplication::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) + 39
    frame #9: 0x00000001000b5aa3 bitcoin-qt`SendCoinsDialog::addEntry(this=0x00000001158a19a0) at sendcoinsdialog.cpp:443 [opt]
    frame #10: 0x00000001000af369 bitcoin-qt`SendCoinsDialog::SendCoinsDialog(this=0x00000001158a19a0, _platformStyle=<unavailable>, parent=<unavailable>) at sendcoinsdialog.cpp:77 [opt]
    frame #11: 0x00000001000f82c7 bitcoin-qt`WalletView::WalletView(this=0x000000011587e250, _platformStyle=<unavailable>, parent=<unavailable>) at walletview.cpp:58 [opt]
    frame #12: 0x00000001000ec68c bitcoin-qt`WalletFrame::addWallet(this=0x000000010c01c460, walletModel=0x0000000111c81fd0) at walletframe.cpp:49 [opt]
    frame #13: 0x000000010001f446 bitcoin-qt`BitcoinGUI::addWallet(this=0x000000010376ce90, walletModel=0x0000000111c81fd0) at bitcoingui.cpp:652 [opt]

IMO we should avoid calling processEvents.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions