@instagibbs @Sjors @MarcoFalke
Quick question
I was taking a look at @Sjors code for signerbumpfee which also allows the user to specify a feeRate.

Lines 161 to 164 in 428dfe0

    
           } else if (options.exists("feeRate")) { 
        
               coin_control.m_feerate = CFeeRate(AmountFromValue(options["feeRate"])); 
        
               coin_control.fOverrideFeeRate = true; 
        
           }

The signerbumpfee rpc eventually calls CreateRateBumpTransaction, which calculates the feeRate to be used as the max between the feeRate passed (minFeeRate) and the old_fee + incrementalRelayFee (feeRate). Thus the feeRate provided by the user is only used if it is larger than old_fee+incrementalRelayFee

bitcoin/src/wallet/feebumper.cpp

Lines 253 to 257 in 428dfe0

    
           // Fee rate must also be at least the wallet's GetMinimumFeeRate 
        
           CFeeRate min_feerate(GetMinimumFeeRate(*wallet, new_coin_control, /* feeCalc */ nullptr)); 
        
           // Set the required fee rate for the replacement transaction in coin control. 
        
           new_coin_control.m_feerate = std::max(feerate, min_feerate);

The implementation I've worked on, always creates the transaction using the feeRate passed in unless the feeRate is invalid. To check whether the feeRate passed in is valid or not, I've made a helper method that follows the same logic used to check the fee for when the TotalFee argument is used.

My question is: What is the desired behavior if the user entered a feeRate that is lower than the old_fee + incrementalRelayFee?
Should we:

Display error notifying the user that the fee is too small
Use the old_fee + incrementalRelayFee as our feeRate (as @Sjors does)
Use the feeRate passed in by the user unless its less than the old_fee or greater than the wallet's maximum fee.

	} else if (options.exists("feeRate")) {
	coin_control.m_feerate = CFeeRate(AmountFromValue(options["feeRate"]));
	coin_control.fOverrideFeeRate = true;
	}

	// Fee rate must also be at least the wallet's GetMinimumFeeRate
	CFeeRate min_feerate(GetMinimumFeeRate(wallet, new_coin_control, / feeCalc */ nullptr));

	// Set the required fee rate for the replacement transaction in coin control.
	new_coin_control.m_feerate = std::max(feerate, min_feerate);

allow feerate argument in bumpfee in addition to confTarget #16203

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

allow feerate argument in `bumpfee` in addition to confTarget #16203