Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bitcoin/bitcoin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: luke-jr/bitcoin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: my_bind_socket_with_handle
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 1 file changed
  • 2 contributors

Commits on Dec 17, 2018

  1. http: Fail initialization when any bind fails 

    Currently the HTTP server initialization (`HTTPBindAddresses`) fails
only when *all* bindings fail. So if multiple binds are specified
(`127.0.0.1` and `::1` by defeault) and one succeeds and the other
fails, the latter is essentially ignored.

This commit changes the error behavior to fail *if not all* binds could
be performed, which I think is more in line with how software normally
handles this and what users expect.
    @laanwj
    laanwj committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    7b5e400 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2018

  1. httpserver: Clone evhttp_bind_socket_with_handle locally

    @luke-jr
    luke-jr committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    c27e066 View commit details
    Browse the repository at this point in the history

  2. httpserver: Preserve socket error from listen across closesocket cleanup

    @luke-jr
    luke-jr committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    8f462f7 View commit details
    Browse the repository at this point in the history

  3. httpserver: Collapse bind_socket into my_bind_socket_with_handle

    @luke-jr
    luke-jr committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    425fcc1 View commit details
    Browse the repository at this point in the history

  4. httpserver: Collapse make_addrinfo into my_bind_socket_with_handle

    @luke-jr
    luke-jr committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    8477274 View commit details
    Browse the repository at this point in the history

  5. httpserver: Only make a single bind_socket_ai call from my_bind_socke… 

    …t_with_handle
    @luke-jr
    luke-jr committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    9ee2515 View commit details
    Browse the repository at this point in the history

  6. httpserver: Collapse bind_socket_ai into my_bind_socket_with_handle

    @luke-jr
    luke-jr committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    aaa64df View commit details
    Browse the repository at this point in the history

  7. httpserver: Adapt my_bind_socket_with_handle to local code style

    @luke-jr
    luke-jr committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    1ab08e1 View commit details
    Browse the repository at this point in the history

  8. httpserver: Simplify my_bind_socket_with_handle

    @luke-jr
    luke-jr committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    2c93368 View commit details
    Browse the repository at this point in the history

  9. httpserver: Check for and tolerate more possible system limitations

    @luke-jr
    luke-jr committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    d2d51e7 View commit details
    Browse the repository at this point in the history
Loading