Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bitcoin/bitcoin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Empact/bitcoin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2020-02-werror
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 4 files changed
  • 2 contributors

Commits on Feb 28, 2020

  1. build: Optionally include Boost headers with -isystem 

    When configured with --enable-isystem.

Note -isystem should not be applied to /usr/include, see
BITCOIN_SYSTEM_INCLUDE for a helper to convert -I to -isystem with
/usr/include excepted.
    @Empact
    Empact committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    fbb7572 View commit details
    Browse the repository at this point in the history

  2. build: change --enable-werror to enable -Werror 

    Before this patch `./configure --enable-werror` would selectively
turn only some warnings into errors, not all, by using
`-Werror=foo -Werror=bar` instead of a plain `-Werror` which turns all
warnings into errors.

To accommodate the new stricter build config, use --enable-isystem to
suppress warnings from external headers (e.g. boost, qt) on systems
that have them installed outside of /usr/include. On Linux the external
headers are typically installed in /usr/include and so warnings from
them are suppressed by default.
    @vasild @Empact
    vasild authored and Empact committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    f43f804 View commit details
    Browse the repository at this point in the history
Loading