util: Document why ArgsManager (con/de)structor is not inline

MarcoFalke · MarcoFalke · commit faf989f93695 · 2020-04-16T12:26:09.000-04:00
diff --git a/src/util/settings.h b/src/util/settings.h
@@ -9,7 +9,7 @@
 #include <string>
 #include <vector>
 
-#include <univalue.h> // For util::SettingsValue = UniValue
+class UniValue;
 
 namespace util {
 
diff --git a/src/util/system.cpp b/src/util/system.cpp
@@ -226,10 +226,11 @@ static bool CheckValid(const std::string& key, const util::SettingsValue& val, u
     return true;
 }
 
-ArgsManager::ArgsManager()
-{
-    // nothing to do
-}
+// Define default constructor and destructor that are not inline, so code instantiating this class doesn't need to
+// #include class definitions for all members.
+// For example, m_settings has an internal dependency on univalue.
+ArgsManager::ArgsManager() {}
+ArgsManager::~ArgsManager() {}
 
 const std::set<std::string> ArgsManager::GetUnsuitableSectionOnlyArgs() const
 {
diff --git a/src/util/system.h b/src/util/system.h
@@ -192,6 +192,7 @@ class ArgsManager
 
 public:
     ArgsManager();
+    ~ArgsManager();
 
     /**
      * Select the network in use

Original file line number	Diff line number	Diff line change
`@@ -226,10 +226,11 @@ static bool CheckValid(const std::string& key, const util::SettingsValue& val, u`
`226`	`226`	`return true;`
`227`	`227`	`}`
`228`	`228`
`229`		`-ArgsManager::ArgsManager()`
`230`		`-{`
`231`		`- // nothing to do`
`232`		`-}`
	`229`	`+// Define default constructor and destructor that are not inline, so code instantiating this class doesn't need to`
	`230`	`+// #include class definitions for all members.`
	`231`	`+// For example, m_settings has an internal dependency on univalue.`
	`232`	`+ArgsManager::ArgsManager() {}`
	`233`	`+ArgsManager::~ArgsManager() {}`
`233`	`234`
`234`	`235`	`const std::set<std::string> ArgsManager::GetUnsuitableSectionOnlyArgs() const`
`235`	`236`	`{`