@@ -328,41 +328,36 @@ BOOST_AUTO_TEST_CASE(coin_selection_tests)
328328 empty_wallet ();
329329}
330330
331- BOOST_AUTO_TEST_CASE (sorting_in_ApproximateBestSet )
331+ BOOST_AUTO_TEST_CASE (ApproximateBestSubset )
332332{
333333 CoinSet setCoinsRet;
334334 CAmount nValueRet;
335335
336336 LOCK (wallet.cs_wallet );
337337
338338 empty_wallet ();
339-
339+
340+ // Test vValue sort order
340341 for (int i = 0 ; i < 1000 ; i++)
341342 add_coin (1000 * COIN);
342343 add_coin (3 * COIN);
343344
344345 BOOST_CHECK (wallet.SelectCoinsMinConf (1003 * COIN, 1 , 6 , vCoins, setCoinsRet, nValueRet));
345346 BOOST_CHECK_EQUAL (nValueRet, 1003 * COIN);
346347 BOOST_CHECK_EQUAL (setCoinsRet.size (), 2U );
347- }
348-
349- BOOST_AUTO_TEST_CASE (pruning_in_ApproximateBestSet)
350- {
351- CoinSet setCoinsRet;
352- CAmount nValueRet;
353-
354- LOCK (wallet.cs_wallet );
355348
356349 empty_wallet ();
350+
351+ // Test trimming
357352 for (int i = 0 ; i < 100 ; i++)
358- add_coin (10 * CENT );
353+ add_coin (10 * COIN );
359354 for (int i = 0 ; i < 100 ; i++)
360- add_coin (1000 * CENT );
355+ add_coin (1000 * COIN );
361356
362- BOOST_CHECK (wallet.SelectCoinsMinConf (100001 * CENT , 1 , 6 , vCoins, setCoinsRet, nValueRet));
357+ BOOST_CHECK (wallet.SelectCoinsMinConf (100001 * COIN , 1 , 6 , vCoins, setCoinsRet, nValueRet));
363358 // We need all 100 larger coins and exactly one small coin.
364- // Superfluous small coins must be pruned :
365- BOOST_CHECK_EQUAL (nValueRet, 100010 * CENT );
359+ // Superfluous small coins must be trimmed from the set :
360+ BOOST_CHECK_EQUAL (nValueRet, 100010 * COIN );
366361 BOOST_CHECK_EQUAL (setCoinsRet.size (), 101 );
367362}
368363
0 commit comments