@@ -218,7 +218,7 @@ General Bitcoin Core
218218 - * Rationale* : RPC allows for better automatic testing. The test suite for
219219 the GUI is very limited
220220
221- - Make sure pulls pass Travis CI before merging
221+ - Make sure pull requests pass Travis CI before merging
222222
223223 - * Rationale* : Makes sure that they pass thorough testing, and that the tester will keep passing
224224 on the master branch. Otherwise all new pull requests will start failing the tests, resulting in
@@ -230,9 +230,9 @@ General Bitcoin Core
230230Wallet
231231-------
232232
233- - Make sure that that no crashes happen with run-time option ` -disablewallet ` .
233+ - Make sure that no crashes happen with run-time option ` -disablewallet ` .
234234
235- - * Rationale* : In RPC code that conditionally use the wallet (such as
235+ - * Rationale* : In RPC code that conditionally uses the wallet (such as
236236 ` validateaddress ` ) it is easy to forget that global pointer ` pwalletMain `
237237 can be NULL. See ` qa/rpc-tests/disablewallet.py ` for functional tests
238238 exercising the API with ` -disablewallet `
@@ -250,9 +250,9 @@ General C++
250250 with assertions disabled, having side-effects in assertions is unexpected and
251251 makes the code harder to understand
252252
253- - If you use the .h , you must link the .cpp
253+ - If you use the ` .h ` , you must link the ` .cpp `
254254
255- - * Rationale* : Include files are the interface for the implementation file . Including one but
255+ - * Rationale* : Include files define the interface for the code in implementation files . Including one but
256256 not linking the other is confusing. Please avoid that. Moving functions from
257257 the ` .h ` to the ` .cpp ` should not result in build errors
258258
@@ -264,11 +264,11 @@ General C++
264264C++ data structures
265265--------------------
266266
267- - Never use the std::map [ ] syntax when reading from a map, but instead use .find()
267+ - Never use the ` std::map [] ` syntax when reading from a map, but instead use ` .find() `
268268
269- - * Rationale* : [ ] does an insert (of the default element) if the item doesn't
269+ - * Rationale* : ` [] ` does an insert (of the default element) if the item doesn't
270270 exist in the map yet. This has resulted in memory leaks in the past, as well as
271- race conditions (expecting read-read behavior). Using [ ] is fine for * writing* to a map
271+ race conditions (expecting read-read behavior). Using ` [] ` is fine for * writing* to a map
272272
273273- Do not compare an iterator from one data structure with an iterator of
274274 another data structure (even if of the same type)
@@ -304,18 +304,18 @@ C++ data structures
304304Strings and formatting
305305------------------------
306306
307- - Be careful of LogPrint versus LogPrintf. LogPrint takes a ' category' argument, LogPrintf does not.
307+ - Be careful of ` LogPrint ` versus ` LogPrintf ` . ` LogPrint ` takes a ` category ` argument, ` LogPrintf ` does not.
308308
309309 - * Rationale* : Confusion of these can result in runtime exceptions due to
310310 formatting mismatch, and it is easy to get wrong because of subtly similar naming
311311
312- - Use std::string, avoid C string manipulation functions
312+ - Use ` std::string ` , avoid C string manipulation functions
313313
314314 - * Rationale* : C++ string handling is marginally safer, less scope for
315- buffer overflows and surprises with \0 characters. Also some C string manipulations
315+ buffer overflows and surprises with ` \0 ` characters. Also some C string manipulations
316316 tend to act differently depending on platform, or even the user locale
317317
318- - Use ParseInt32, ParseInt64, ParseDouble from ` utilstrencodings.h ` for number parsing
318+ - Use ` ParseInt32 ` , ` ParseInt64 ` , ` ParseDouble ` from ` utilstrencodings.h ` for number parsing
319319
320320 - * Rationale* : These functions do overflow checking, and avoid pesky locale issues
321321
0 commit comments