refactor: Avoid GCC false positive error

MarcoFalke · MarcoFalke · commit fa8ade300f42 · 2025-01-20T17:43:58.000+01:00
This avoids an overly agressive GCC false positive warning:

error: ‘tmp’ may be used uninitialized [-Werror=maybe-uninitialized]
diff --git a/src/test/fuzz/float.cpp b/src/test/fuzz/float.cpp
@@ -1,4 +1,4 @@
-// Copyright (c) 2020-2021 The Bitcoin Core developers
+// Copyright (c) 2020-present The Bitcoin Core developers
 // Distributed under the MIT software license, see the accompanying
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
@@ -11,14 +11,15 @@
 #include <cassert>
 #include <cmath>
 #include <limits>
+#include <optional>
 
 FUZZ_TARGET(float)
 {
     FuzzedDataProvider fuzzed_data_provider(buffer.data(), buffer.size());
 
     {
         const double d{[&] {
-            double tmp;
+            std::optional<double> tmp;
             CallOneOf(
                 fuzzed_data_provider,
                 // an actual number
@@ -42,7 +43,7 @@ FUZZ_TARGET(float)
                       }); },
                 // Anything from raw memory (also checks that DecodeDouble doesn't crash on any input)
                 [&] { tmp = DecodeDouble(fuzzed_data_provider.ConsumeIntegral<uint64_t>()); });
-            return tmp;
+            return *tmp;
         }()};
         (void)memusage::DynamicUsage(d);
 
