mempool: Don't sort in entryAll

sedited · sedited · commit f761f0306b09 · 2023-12-10T11:10:51.000+01:00
Current call sites of entryAll do not require the entries to be sorted,
so iterate through mapTx directly to retrieve the entries instead of
using SortedDepthAndScore.
diff --git a/src/txmempool.cpp b/src/txmempool.cpp
@@ -829,13 +829,7 @@ static TxMempoolInfo GetInfo(CTxMemPool::indexed_transaction_set::const_iterator
 std::vector<CTxMemPoolEntryRef> CTxMemPool::entryAll() const
 {
     AssertLockHeld(cs);
-
-    std::vector<CTxMemPoolEntryRef> ret;
-    ret.reserve(mapTx.size());
-    for (const auto& it : GetSortedDepthAndScore()) {
-        ret.emplace_back(*it);
-    }
-    return ret;
+    return {mapTx.begin(), mapTx.end()};
 }
 
 std::vector<TxMempoolInfo> CTxMemPool::infoAll() const

Original file line number	Diff line number	Diff line change
`@@ -829,13 +829,7 @@ static TxMempoolInfo GetInfo(CTxMemPool::indexed_transaction_set::const_iterator`
`829`	`829`	`std::vector<CTxMemPoolEntryRef> CTxMemPool::entryAll() const`
`830`	`830`	`{`
`831`	`831`	`AssertLockHeld(cs);`
`832`		`-`
`833`		`- std::vector<CTxMemPoolEntryRef> ret;`
`834`		`- ret.reserve(mapTx.size());`
`835`		`- for (const auto& it : GetSortedDepthAndScore()) {`
`836`		`- ret.emplace_back(*it);`
`837`		`- }`
`838`		`- return ret;`
	`832`	`+ return {mapTx.begin(), mapTx.end()};`
`839`	`833`	`}`
`840`	`834`
`841`	`835`	`std::vector<TxMempoolInfo> CTxMemPool::infoAll() const`