refactor: move flags to private uint8_t and rename to m_flags

andrewtoth · andrewtoth · commit f08faeade2f9 · 2024-08-01T23:36:00.000-04:00
No behavior change. This prepares to add CCoinsCacheEntrys
to a doubly linked list when a flag is added.
diff --git a/src/coins.h b/src/coins.h
@@ -103,8 +103,11 @@ class Coin
  */
 struct CCoinsCacheEntry
 {
+private:
+    uint8_t m_flags{0};
+
+public:
     Coin coin; // The actual cached data.
-    unsigned char flags{0};
 
     enum Flags {
         /**
@@ -130,14 +133,14 @@ struct CCoinsCacheEntry
     CCoinsCacheEntry() noexcept = default;
     explicit CCoinsCacheEntry(Coin&& coin_) noexcept : coin(std::move(coin_)) {}
 
-    inline void AddFlags(unsigned char flags) noexcept { this->flags |= flags; }
+    inline void AddFlags(uint8_t flags) noexcept { m_flags |= flags; }
     inline void ClearFlags() noexcept
     {
-        flags = 0;
+        m_flags = 0;
     }
-    inline unsigned char GetFlags() const noexcept { return flags; }
-    inline bool IsDirty() const noexcept { return flags & DIRTY; }
-    inline bool IsFresh() const noexcept { return flags & FRESH; }
+    inline uint8_t GetFlags() const noexcept { return m_flags; }
+    inline bool IsDirty() const noexcept { return m_flags & DIRTY; }
+    inline bool IsFresh() const noexcept { return m_flags & FRESH; }
 };
 
 /**
diff --git a/src/test/fuzz/coins_view.cpp b/src/test/fuzz/coins_view.cpp
@@ -125,7 +125,7 @@ FUZZ_TARGET(coins_view, .init = initialize_coins_view)
                 LIMITED_WHILE(good_data && fuzzed_data_provider.ConsumeBool(), 10'000)
                 {
                     CCoinsCacheEntry coins_cache_entry;
-                    coins_cache_entry.AddFlags(fuzzed_data_provider.ConsumeIntegral<unsigned char>());
+                    coins_cache_entry.AddFlags(fuzzed_data_provider.ConsumeIntegral<uint8_t>());
                     if (fuzzed_data_provider.ConsumeBool()) {
                         coins_cache_entry.coin = random_coin;
                     } else {

Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ FUZZ_TARGET(coins_view, .init = initialize_coins_view)`
`125`	`125`	`LIMITED_WHILE(good_data && fuzzed_data_provider.ConsumeBool(), 10'000)`
`126`	`126`	`{`
`127`	`127`	`CCoinsCacheEntry coins_cache_entry;`
`128`		`- coins_cache_entry.AddFlags(fuzzed_data_provider.ConsumeIntegral<unsigned char>());`
	`128`	`+ coins_cache_entry.AddFlags(fuzzed_data_provider.ConsumeIntegral<uint8_t>());`
`129`	`129`	`if (fuzzed_data_provider.ConsumeBool()) {`
`130`	`130`	`coins_cache_entry.coin = random_coin;`
`131`	`131`	`} else {`