You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+2Lines changed: 2 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -95,6 +95,8 @@ Anyone may participate in peer review which is expressed by comments in the pull
95
95
- Concept ACK means "I agree in the general principle of this pull request";
96
96
- Nit refers to trivial, often non-blocking issues.
97
97
98
+
Reviewers should include the commit hash which they reviewed in their comments.
99
+
98
100
Project maintainers reserve the right to weigh the opinions of peer reviewers using common sense judgement and also may weight based on meritocracy: Those that have demonstrated a deeper commitment and understanding towards the project (over time) or have clear domain expertise may naturally have more weight, as one would expect in all walks of life.
99
101
100
102
Where a patch set affects consensus critical code, the bar will be set much higher in terms of discussion and peer review requirements, keeping in mind that mistakes could be very costly to the wider community. This includes refactoring of consensus critical code.
Copy file name to clipboardExpand all lines: build-aux/m4/bitcoin_find_bdb48.m4
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -38,7 +38,7 @@ AC_DEFUN([BITCOIN_FIND_BDB48],[
38
38
done
39
39
if test "x$bdbpath" = "xX"; then
40
40
AC_MSG_RESULT([no])
41
-
AC_MSG_ERROR([libdb_cxx headers missing, Bitcoin Core requires this library for wallet functionality (--disable-wallet to disable wallet functionality)])
41
+
AC_MSG_ERROR([libdb_cxx headers missing, ]AC_PACKAGE_NAME[ requires this library for wallet functionality (--disable-wallet to disable wallet functionality)])
0 commit comments