move-only: make GetInfo a private CTxMemPool member

stickies-v · marcofleon · commit de858ce2bea8 · 2025-07-08T19:30:48.000+01:00
This allows it to be used by templated functions in a future commit.
diff --git a/src/txmempool.cpp b/src/txmempool.cpp
@@ -844,10 +844,6 @@ std::vector<CTxMemPool::indexed_transaction_set::const_iterator> CTxMemPool::Get
     return iters;
 }
 
-static TxMempoolInfo GetInfo(CTxMemPool::indexed_transaction_set::const_iterator it) {
-    return TxMempoolInfo{it->GetSharedTx(), it->GetTime(), it->GetFee(), it->GetTxSize(), it->GetModifiedFee() - it->GetFee()};
-}
-
 std::vector<CTxMemPoolEntryRef> CTxMemPool::entryAll() const
 {
     AssertLockHeld(cs);
diff --git a/src/txmempool.h b/src/txmempool.h
@@ -431,6 +431,11 @@ class CTxMemPool
                                                               const Limits& limits
                                                               ) const EXCLUSIVE_LOCKS_REQUIRED(cs);
 
+    static TxMempoolInfo GetInfo(CTxMemPool::indexed_transaction_set::const_iterator it)
+    {
+        return TxMempoolInfo{it->GetSharedTx(), it->GetTime(), it->GetFee(), it->GetTxSize(), it->GetModifiedFee() - it->GetFee()};
+    }
+
 public:
     indirectmap<COutPoint, const CTransaction*> mapNextTx GUARDED_BY(cs);
     std::map<uint256, CAmount> mapDeltas GUARDED_BY(cs);

Original file line number	Diff line number	Diff line change
`@@ -844,10 +844,6 @@ std::vector<CTxMemPool::indexed_transaction_set::const_iterator> CTxMemPool::Get`
`844`	`844`	`return iters;`
`845`	`845`	`}`
`846`	`846`
`847`		`-static TxMempoolInfo GetInfo(CTxMemPool::indexed_transaction_set::const_iterator it) {`
`848`		`- return TxMempoolInfo{it->GetSharedTx(), it->GetTime(), it->GetFee(), it->GetTxSize(), it->GetModifiedFee() - it->GetFee()};`
`849`		`-}`
`850`		`-`
`851`	`847`	`std::vector<CTxMemPoolEntryRef> CTxMemPool::entryAll() const`
`852`	`848`	`{`
`853`	`849`	`AssertLockHeld(cs);`