kernel: Remove chainman destructor in bitcoinkernel.cpp

sedited · sedited · commit d9cc26d3b2b5 · 2025-11-07T10:18:27.000+01:00
There is no need to flush the background callbacks, since the immediate
task runner is used for the validation signals, which does not have any
pending callbacks. This allows for removal of the code in the
destructor.
diff --git a/src/kernel/bitcoinkernel.cpp b/src/kernel/bitcoinkernel.cpp
@@ -1000,15 +1000,6 @@ const btck_BlockTreeEntry* btck_chainstate_manager_get_block_tree_entry_by_hash(
 
 void btck_chainstate_manager_destroy(btck_ChainstateManager* chainman)
 {
-    {
-        LOCK(btck_ChainstateManager::get(chainman).m_chainman->GetMutex());
-        for (Chainstate* chainstate : btck_ChainstateManager::get(chainman).m_chainman->GetAll()) {
-            if (chainstate->CanFlushToDisk()) {
-                chainstate->ForceFlushStateToDisk();
-            }
-        }
-    }
-
     delete chainman;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1000,15 +1000,6 @@ const btck_BlockTreeEntry* btck_chainstate_manager_get_block_tree_entry_by_hash(`
`1000`	`1000`
`1001`	`1001`	`void btck_chainstate_manager_destroy(btck_ChainstateManager* chainman)`
`1002`	`1002`	`{`
`1003`		`- {`
`1004`		`- LOCK(btck_ChainstateManager::get(chainman).m_chainman->GetMutex());`
`1005`		`- for (Chainstate* chainstate : btck_ChainstateManager::get(chainman).m_chainman->GetAll()) {`
`1006`		`- if (chainstate->CanFlushToDisk()) {`
`1007`		`- chainstate->ForceFlushStateToDisk();`
`1008`		`- }`
`1009`		`- }`
`1010`		`- }`
`1011`		`-`
`1012`	`1003`	`delete chainman;`
`1013`	`1004`	`}`
`1014`	`1005`