Clear any input_errors for an input after it is signed

achow101 · achow101 · commit d2774c09cfcc · 2020-03-09T11:16:20.000-04:00
Make sure that there are no errors set for an input after it is signed.
This is useful for when there are multiple ScriptPubKeyMans. Some may
fail to sign, but one may be able to sign, and after it does, we don't
want there to be any more errors there.
diff --git a/src/script/sign.cpp b/src/script/sign.cpp
@@ -509,6 +509,9 @@ bool SignTransaction(CMutableTransaction& mtx, const SigningProvider* keystore,
             } else {
                 input_errors[i] = ScriptErrorString(serror);
             }
+        } else {
+            // If this input succeeds, make sure there is no error set for it
+            input_errors.erase(i);
         }
     }
     return input_errors.empty();

Original file line number	Diff line number	Diff line change
`@@ -509,6 +509,9 @@ bool SignTransaction(CMutableTransaction& mtx, const SigningProvider* keystore,`
`509`	`509`	`} else {`
`510`	`510`	`input_errors[i] = ScriptErrorString(serror);`
`511`	`511`	`}`
	`512`	`+ } else {`
	`513`	`+ // If this input succeeds, make sure there is no error set for it`
	`514`	`+ input_errors.erase(i);`
`512`	`515`	`}`
`513`	`516`	`}`
`514`	`517`	`return input_errors.empty();`