fixup! [wallet] Construct CWalletTx objects in CommitTransaction

ryanofsky · ryanofsky · commit d070a69e9734 · 2017-12-01T17:08:24.000-05:00
Avoid shared_ptr deserialize as suggested #9680 (comment)
diff --git a/src/qt/walletmodel.cpp b/src/qt/walletmodel.cpp
@@ -335,7 +335,7 @@ WalletModel::SendCoinsReturn WalletModel::sendCoins(WalletModelTransaction &tran
             return SendCoinsReturn(TransactionCommitFailed, QString::fromStdString(state.GetRejectReason()));
 
         CDataStream ssTx(SER_NETWORK, PROTOCOL_VERSION);
-        ssTx << **newTx;
+        ssTx << *newTx;
         transaction_array.append(&(ssTx[0]), ssTx.size());
     }
 

Original file line number	Diff line number	Diff line change
`@@ -335,7 +335,7 @@ WalletModel::SendCoinsReturn WalletModel::sendCoins(WalletModelTransaction &tran`
`335`	`335`	`return SendCoinsReturn(TransactionCommitFailed, QString::fromStdString(state.GetRejectReason()));`
`336`	`336`
`337`	`337`	`CDataStream ssTx(SER_NETWORK, PROTOCOL_VERSION);`
`338`		`- ssTx << **newTx;`
	`338`	`+ ssTx << *newTx;`
`339`	`339`	`transaction_array.append(&(ssTx[0]), ssTx.size());`
`340`	`340`	`}`
`341`	`341`