Skip to content

Commit cd986ea

Browse files
committed
Run Qt wallet tests on travis
Currently these test failures are not caught by travis leading to bugs like: #10506
1 parent bea5b00 commit cd986ea

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

.travis.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ env:
2929
- HOST=i686-pc-linux-gnu PACKAGES="g++-multilib bc python3-zmq" DEP_OPTS="NO_QT=1" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-zmq --enable-glibc-back-compat --enable-reduce-exports LDFLAGS=-static-libstdc++" USE_SHELL="/bin/dash"
3030
# Win64
3131
- HOST=x86_64-w64-mingw32 DPKG_ADD_ARCH="i386" DEP_OPTS="NO_QT=1" PACKAGES="python3 nsis g++-mingw-w64-x86-64 wine1.6 bc" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-reduce-exports"
32-
# bitcoind
33-
- HOST=x86_64-unknown-linux-gnu PACKAGES="bc python3-zmq" DEP_OPTS="NO_QT=1 NO_UPNP=1 DEBUG=1" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-zmq --enable-glibc-back-compat --enable-reduce-exports CPPFLAGS=-DDEBUG_LOCKORDER"
34-
# No wallet
32+
# x86_64 Linux (uses qt5 dev package instead of depends Qt to speed up build and avoid timeout)
33+
- HOST=x86_64-unknown-linux-gnu PACKAGES="python3-zmq qtbase5-dev qttools5-dev-tools protobuf-compiler libdbus-1-dev libharfbuzz-dev" DEP_OPTS="NO_QT=1 NO_UPNP=1 DEBUG=1 HOST_PKG=1" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-zmq --with-gui=qt5 --enable-glibc-back-compat --enable-reduce-exports CPPFLAGS=-DDEBUG_LOCKORDER"
34+
# x86_64 Linux, No wallet
3535
- HOST=x86_64-unknown-linux-gnu PACKAGES="python3" DEP_OPTS="NO_WALLET=1" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-glibc-back-compat --enable-reduce-exports"
3636
# Cross-Mac
3737
- HOST=x86_64-apple-darwin11 PACKAGES="cmake imagemagick libcap-dev librsvg2-bin libz-dev libbz2-dev libtiff-tools python-dev" BITCOIN_CONFIG="--enable-gui --enable-reduce-exports" OSX_SDK=10.11 GOAL="deploy"

depends/Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@ $(host_prefix)/share/config.site : config.site.in $(host_prefix)/.stamp_$(final_
134134
-e 's|@CXXFLAGS@|$(strip $(host_CXXFLAGS) $(host_$(release_type)_CXXFLAGS))|' \
135135
-e 's|@CPPFLAGS@|$(strip $(host_CPPFLAGS) $(host_$(release_type)_CPPFLAGS))|' \
136136
-e 's|@LDFLAGS@|$(strip $(host_LDFLAGS) $(host_$(release_type)_LDFLAGS))|' \
137+
-e 's|@host_pkg@|$(HOST_PKG)|' \
137138
-e 's|@no_qt@|$(NO_QT)|' \
138139
-e 's|@no_wallet@|$(NO_WALLET)|' \
139140
-e 's|@no_upnp@|$(NO_UPNP)|' \

depends/config.site.in

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ fi
1313
if test -z $with_qt_translationdir; then
1414
with_qt_translationdir=$depends_prefix/translations
1515
fi
16-
if test -z $with_qt_bindir; then
16+
if test -z $with_qt_bindir && test "x@host_pkg@" = x; then
1717
with_qt_bindir=$depends_prefix/native/bin
1818
fi
19-
if test -z $with_protoc_bindir; then
19+
if test -z $with_protoc_bindir && test "x@host_pkg@" = x; then
2020
with_protoc_bindir=$depends_prefix/native/bin
2121
fi
2222

@@ -57,6 +57,11 @@ PKG_CONFIG="`which pkg-config` --static"
5757
export PKG_CONFIG_LIBDIR=$depends_prefix/lib/pkgconfig
5858
export PKG_CONFIG_PATH=$depends_prefix/share/pkgconfig
5959

60+
if test "x@host_pkg@" != x; then
61+
PKG_CONFIG_PATH="$PKG_CONFIG_PATH:$PKG_CONFIG_LIBDIR"
62+
unset PKG_CONFIG_LIBDIR
63+
fi
64+
6065
CPPFLAGS="-I$depends_prefix/include/ $CPPFLAGS"
6166
LDFLAGS="-L$depends_prefix/lib $LDFLAGS"
6267

0 commit comments

Comments
 (0)