util: Don't reference errno when pthread fails.

miztake · hebasto · miztake · commit cb38b069b0f4 · 2020-06-08T16:37:59.000+09:00
Pthread library does not set errno.
Pthread library's errno is returned by return value.

Co-authored-by: Hennadii Stepanov &lt;32963518+hebasto@users.noreply.github.com&gt;
diff --git a/src/util/system.cpp b/src/util/system.cpp
@@ -1163,8 +1163,9 @@ void ScheduleBatchPriority()
 {
 #ifdef SCHED_BATCH
     const static sched_param param{};
-    if (pthread_setschedparam(pthread_self(), SCHED_BATCH, &param) != 0) {
-        LogPrintf("Failed to pthread_setschedparam: %s\n", strerror(errno));
+    const int rc = pthread_setschedparam(pthread_self(), SCHED_BATCH, &param);
+    if (rc != 0) {
+        LogPrintf("Failed to pthread_setschedparam: %s\n", strerror(rc));
     }
 #endif
 }

Original file line number	Diff line number	Diff line change
`@@ -1163,8 +1163,9 @@ void ScheduleBatchPriority()`
`1163`	`1163`	`{`
`1164`	`1164`	`#ifdef SCHED_BATCH`
`1165`	`1165`	`const static sched_param param{};`
`1166`		`- if (pthread_setschedparam(pthread_self(), SCHED_BATCH, &param) != 0) {`
`1167`		`- LogPrintf("Failed to pthread_setschedparam: %s\n", strerror(errno));`
	`1166`	`+ const int rc = pthread_setschedparam(pthread_self(), SCHED_BATCH, &param);`
	`1167`	`+ if (rc != 0) {`
	`1168`	`+ LogPrintf("Failed to pthread_setschedparam: %s\n", strerror(rc));`
`1168`	`1169`	`}`
`1169`	`1170`	`#endif`
`1170`	`1171`	`}`