clang-tidy: Fix critical warnings

fjahr · fjahr · commit c76797481155 · 2025-09-07T17:28:31.000+02:00
The std::move in coinstatsindex was not necessary since it was passed as a const reference argument.

The other change in the utxo supply fuzz test changes a line that seems to have triggered a false alarm.
diff --git a/src/index/coinstatsindex.cpp b/src/index/coinstatsindex.cpp
@@ -256,7 +256,7 @@ bool CoinStatsIndex::CustomAppend(const interfaces::BlockInfo& block)
         return false;
     }
 
-    batch.Write(DBHashKey(value.first), std::move(value.second));
+    batch.Write(DBHashKey(value.first), value.second);
     return true;
 }
 
diff --git a/src/test/fuzz/utxo_total_supply.cpp b/src/test/fuzz/utxo_total_supply.cpp
@@ -153,7 +153,7 @@ FUZZ_TARGET(utxo_total_supply)
                 node::RegenerateCommitments(*current_block, chainman);
                 const bool was_valid = !MineBlock(node, current_block).IsNull();
 
-                const auto prev_utxo_stats = utxo_stats;
+                const uint256 prev_hash_serialized{utxo_stats.hashSerialized};
                 if (was_valid) {
                     if (duplicate_coinbase_height == ActiveHeight()) {
                         // we mined the duplicate coinbase
@@ -167,7 +167,7 @@ FUZZ_TARGET(utxo_total_supply)
 
                 if (!was_valid) {
                     // utxo stats must not change
-                    assert(prev_utxo_stats.hashSerialized == utxo_stats.hashSerialized);
+                    assert(prev_hash_serialized == utxo_stats.hashSerialized);
                 }
 
                 current_block = PrepareNextBlock();

Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,7 @@ bool CoinStatsIndex::CustomAppend(const interfaces::BlockInfo& block)`
`256`	`256`	`return false;`
`257`	`257`	`}`
`258`	`258`
`259`		`- batch.Write(DBHashKey(value.first), std::move(value.second));`
	`259`	`+ batch.Write(DBHashKey(value.first), value.second);`
`260`	`260`	`return true;`
`261`	`261`	`}`
`262`	`262`