wallet: update settxfee help

jonatack · jonatack · commit c594a002845e · 2021-01-28T21:21:57.000+01:00
diff --git a/doc/release-notes-20391.md b/doc/release-notes-20391.md
@@ -1,3 +1,10 @@
+Updated RPCs
+------------
+
+- `settxfee` is marked as deprecated in favor of the new `setfeerate` RPC
+  described in the "New RPCs" section. This change is part of a larger migration
+  from BTC/kvB to sat/vB units for fee rates. (#20391)
+
 New RPCs
 ------------
 
diff --git a/src/wallet/rpcwallet.cpp b/src/wallet/rpcwallet.cpp
@@ -2310,10 +2310,12 @@ static RPCHelpMan listlockunspent()
 static RPCHelpMan settxfee()
 {
     return RPCHelpMan{"settxfee",
-                "\nSet the transaction fee per kB for this wallet. Overrides the global -paytxfee command line parameter.\n"
-                "Can be deactivated by passing 0 as the fee. In that case automatic fee selection will be used by default.\n",
+                "\n(Deprecated in favor of the setfeerate RPC in " + CURRENCY_ATOM + "/vB, which it is recommended to use instead.)\n"
+                "Set the transaction fee rate in " + CURRENCY_UNIT + "/kvB for this wallet.\n"
+                "Overrides the global -paytxfee configuration option. Like -paytxfee, it is not persisted after bitcoind shutdown/restart.\n"
+                "Can be deactivated by passing 0 as the fee rate, in which case automatic fee selection will be used by default.\n",
                 {
-                    {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The transaction fee in " + CURRENCY_UNIT + "/kvB"},
+                    {"amount", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "The transaction fee rate in " + CURRENCY_UNIT + "/kvB to set (0 to unset)"},
                 },
                 RPCResult{
                     RPCResult::Type::BOOL, "", "Returns true if successful"
