CBase58Data::SetString: cleanse the full vector

kazcw · MarcoFalke · commit c3d1bc33b598 · 2016-06-04T18:01:02.000+02:00
SetString seems to be passing the length of the wrong variable to memory_cleanse, resulting in the last byte of the temporary buffer not being securely erased. Github-Pull: #7922 Rebased-From: 5770449
diff --git a/src/base58.cpp b/src/base58.cpp
@@ -172,7 +172,7 @@ bool CBase58Data::SetString(const char* psz, unsigned int nVersionBytes)
     vchData.resize(vchTemp.size() - nVersionBytes);
     if (!vchData.empty())
         memcpy(&vchData[0], &vchTemp[nVersionBytes], vchData.size());
-    memory_cleanse(&vchTemp[0], vchData.size());
+    memory_cleanse(&vchTemp[0], vchTemp.size());
     return true;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,7 @@ bool CBase58Data::SetString(const char* psz, unsigned int nVersionBytes)`
`172`	`172`	`vchData.resize(vchTemp.size() - nVersionBytes);`
`173`	`173`	`if (!vchData.empty())`
`174`	`174`	`memcpy(&vchData[0], &vchTemp[nVersionBytes], vchData.size());`
`175`		`- memory_cleanse(&vchTemp[0], vchData.size());`
	`175`	`+ memory_cleanse(&vchTemp[0], vchTemp.size());`
`176`	`176`	`return true;`
`177`	`177`	`}`
`178`	`178`