TX_MISSING_INPUTS now has a DoS score of 0

sdaftuar · sdaftuar · commit bee1d4f5e29c · 2019-02-08T13:54:11.000-05:00
The DoS value is rewritten to be 100 during block validation, and it is
ignored during mempool acceptance. Change it to 0 in preparation for later
commits, where it will become more explicit that TX_MISSING_INPUTS doesn't
result in DoS points for transactions.
diff --git a/src/consensus/tx_verify.cpp b/src/consensus/tx_verify.cpp
@@ -209,7 +209,7 @@ bool Consensus::CheckTxInputs(const CTransaction& tx, CValidationState& state, c
 {
     // are the actual inputs available?
     if (!inputs.HaveInputs(tx)) {
-        return state.DoS(100, ValidationInvalidReason::TX_MISSING_INPUTS, false, REJECT_INVALID, "bad-txns-inputs-missingorspent", false,
+        return state.DoS(0, ValidationInvalidReason::TX_MISSING_INPUTS, false, REJECT_INVALID, "bad-txns-inputs-missingorspent", false,
                          strprintf("%s: inputs missing/spent", __func__));
     }
 
@@ -221,7 +221,7 @@ bool Consensus::CheckTxInputs(const CTransaction& tx, CValidationState& state, c
 
         // If prev is coinbase, check that it's matured
         if (coin.IsCoinBase() && nSpendHeight - coin.nHeight < COINBASE_MATURITY) {
-            return state.DoS(100, ValidationInvalidReason::TX_MISSING_INPUTS, false,
+            return state.DoS(0, ValidationInvalidReason::TX_MISSING_INPUTS, false,
                 REJECT_INVALID, "bad-txns-premature-spend-of-coinbase", false,
                 strprintf("tried to spend coinbase at depth %d", nSpendHeight - coin.nHeight));
         }
diff --git a/src/consensus/validation.h b/src/consensus/validation.h
@@ -137,14 +137,14 @@ class CValidationState {
         case ValidationInvalidReason::BLOCK_INVALID_HEADER:
         case ValidationInvalidReason::BLOCK_CHECKPOINT:
         case ValidationInvalidReason::BLOCK_INVALID_PREV:
-        case ValidationInvalidReason::TX_MISSING_INPUTS:
             return 100;
         case ValidationInvalidReason::BLOCK_MISSING_PREV:
             return 10;
         case ValidationInvalidReason::CACHED_INVALID:
         case ValidationInvalidReason::RECENT_CONSENSUS_CHANGE:
         case ValidationInvalidReason::BLOCK_BAD_TIME:
         case ValidationInvalidReason::TX_NOT_STANDARD:
+        case ValidationInvalidReason::TX_MISSING_INPUTS:
         case ValidationInvalidReason::TX_WITNESS_MUTATED:
         case ValidationInvalidReason::TX_CONFLICT:
         case ValidationInvalidReason::TX_MEMPOOL_POLICY:

Original file line number	Diff line number	Diff line change
`@@ -209,7 +209,7 @@ bool Consensus::CheckTxInputs(const CTransaction& tx, CValidationState& state, c`
`209`	`209`	`{`
`210`	`210`	`// are the actual inputs available?`
`211`	`211`	`if (!inputs.HaveInputs(tx)) {`
`212`		`- return state.DoS(100, ValidationInvalidReason::TX_MISSING_INPUTS, false, REJECT_INVALID, "bad-txns-inputs-missingorspent", false,`
	`212`	`+ return state.DoS(0, ValidationInvalidReason::TX_MISSING_INPUTS, false, REJECT_INVALID, "bad-txns-inputs-missingorspent", false,`
`213`	`213`	`strprintf("%s: inputs missing/spent", __func__));`
`214`	`214`	`}`
`215`	`215`
`@@ -221,7 +221,7 @@ bool Consensus::CheckTxInputs(const CTransaction& tx, CValidationState& state, c`
`221`	`221`
`222`	`222`	`// If prev is coinbase, check that it's matured`
`223`	`223`	`if (coin.IsCoinBase() && nSpendHeight - coin.nHeight < COINBASE_MATURITY) {`
`224`		`- return state.DoS(100, ValidationInvalidReason::TX_MISSING_INPUTS, false,`
	`224`	`+ return state.DoS(0, ValidationInvalidReason::TX_MISSING_INPUTS, false,`
`225`	`225`	`REJECT_INVALID, "bad-txns-premature-spend-of-coinbase", false,`
`226`	`226`	`strprintf("tried to spend coinbase at depth %d", nSpendHeight - coin.nHeight));`
`227`	`227`	`}`