Add attribute [[noreturn]] (C++11) to functions that will not return

practicalswift · practicalswift · commit b82c55af7873 · 2017-07-17T18:46:18.000+02:00
Rationale:
* Reduce the number of false positives from static analyzers
* Potentially enable additional compiler optimizations
diff --git a/src/random.cpp b/src/random.cpp
@@ -39,10 +39,10 @@
 #include <openssl/err.h>
 #include <openssl/rand.h>
 
-static void RandFailure()
+[[noreturn]] static void RandFailure()
 {
     LogPrintf("Failed to read randomness, aborting\n");
-    abort();
+    std::abort();
 }
 
 static inline int64_t GetPerformanceCounter()
diff --git a/src/test/test_bitcoin_main.cpp b/src/test/test_bitcoin_main.cpp
@@ -10,14 +10,14 @@
 
 std::unique_ptr<CConnman> g_connman;
 
-void Shutdown(void* parg)
+[[noreturn]] void Shutdown(void* parg)
 {
-  exit(EXIT_SUCCESS);
+  std::exit(EXIT_SUCCESS);
 }
 
-void StartShutdown()
+[[noreturn]] void StartShutdown()
 {
-  exit(EXIT_SUCCESS);
+  std::exit(EXIT_SUCCESS);
 }
 
 bool ShutdownRequested()

Original file line number	Diff line number	Diff line change
`@@ -39,10 +39,10 @@`
`39`	`39`	`#include <openssl/err.h>`
`40`	`40`	`#include <openssl/rand.h>`
`41`	`41`
`42`		`-static void RandFailure()`
	`42`	`+[[noreturn]] static void RandFailure()`
`43`	`43`	`{`
`44`	`44`	`LogPrintf("Failed to read randomness, aborting\n");`
`45`		`- abort();`
	`45`	`+ std::abort();`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`static inline int64_t GetPerformanceCounter()`
Original file line number	Diff line number	Diff line change
`@@ -10,14 +10,14 @@`
`10`	`10`
`11`	`11`	`std::unique_ptr<CConnman> g_connman;`
`12`	`12`
`13`		`-void Shutdown(void* parg)`
	`13`	`+[[noreturn]] void Shutdown(void* parg)`
`14`	`14`	`{`
`15`		`- exit(EXIT_SUCCESS);`
	`15`	`+ std::exit(EXIT_SUCCESS);`
`16`	`16`	`}`
`17`	`17`
`18`		`-void StartShutdown()`
	`18`	`+[[noreturn]] void StartShutdown()`
`19`	`19`	`{`
`20`		`- exit(EXIT_SUCCESS);`
	`20`	`+ std::exit(EXIT_SUCCESS);`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`bool ShutdownRequested()`