Remove unused C++ code not covered by unit tests

practicalswift · practicalswift · commit b51aaf1c42d9 · 2017-04-26T21:20:02.000+02:00
diff --git a/src/chainparamsbase.cpp b/src/chainparamsbase.cpp
@@ -103,8 +103,3 @@ std::string ChainNameFromCommandLine()
         return CBaseChainParams::TESTNET;
     return CBaseChainParams::MAIN;
 }
-
-bool AreBaseParamsConfigured()
-{
-    return pCurrentBaseParams != NULL;
-}
diff --git a/src/chainparamsbase.h b/src/chainparamsbase.h
@@ -53,10 +53,4 @@ void SelectBaseParams(const std::string& chain);
  */
 std::string ChainNameFromCommandLine();
 
-/**
- * Return true if SelectBaseParamsFromCommandLine() has been called to select
- * a network.
- */
-bool AreBaseParamsConfigured();
-
 #endif // BITCOIN_CHAINPARAMSBASE_H
diff --git a/src/key.cpp b/src/key.cpp
@@ -131,14 +131,6 @@ void CKey::MakeNewKey(bool fCompressedIn) {
     fCompressed = fCompressedIn;
 }
 
-bool CKey::SetPrivKey(const CPrivKey &privkey, bool fCompressedIn) {
-    if (!ec_privkey_import_der(secp256k1_context_sign, (unsigned char*)begin(), &privkey[0], privkey.size()))
-        return false;
-    fCompressed = fCompressedIn;
-    fValid = true;
-    return true;
-}
-
 CPrivKey CKey::GetPrivKey() const {
     assert(fValid);
     CPrivKey privkey;
diff --git a/src/key.h b/src/key.h
@@ -94,9 +94,6 @@ class CKey
     //! Check whether the public key corresponding to this private key is (to be) compressed.
     bool IsCompressed() const { return fCompressed; }
 
-    //! Initialize from a CPrivKey (serialized OpenSSL private key data).
-    bool SetPrivKey(const CPrivKey& vchPrivKey, bool fCompressed);
-
     //! Generate a new private key using a cryptographic PRNG.
     void MakeNewKey(bool fCompressed);
 
diff --git a/src/netaddress.cpp b/src/netaddress.cpp
@@ -179,12 +179,6 @@ bool CNetAddr::IsLocal() const
    return false;
 }
 
-bool CNetAddr::IsMulticast() const
-{
-    return    (IsIPv4() && (GetByte(3) & 0xF0) == 0xE0)
-           || (GetByte(15) == 0xFF);
-}
-
 bool CNetAddr::IsValid() const
 {
     // Cleanup 3-byte shifted addresses caused by garbage in size field
diff --git a/src/netaddress.h b/src/netaddress.h
@@ -65,7 +65,6 @@ class CNetAddr
         bool IsLocal() const;
         bool IsRoutable() const;
         bool IsValid() const;
-        bool IsMulticast() const;
         enum Network GetNetwork() const;
         std::string ToString() const;
         std::string ToStringIP() const;
diff --git a/src/script/interpreter.cpp b/src/script/interpreter.cpp
@@ -247,10 +247,10 @@ bool EvalScript(std::vector<std::vector<unsigned char> >& stack, const CScript&
 {
     static const CScriptNum bnZero(0);
     static const CScriptNum bnOne(1);
-    static const CScriptNum bnFalse(0);
-    static const CScriptNum bnTrue(1);
+    // static const CScriptNum bnFalse(0);
+    // static const CScriptNum bnTrue(1);
     static const valtype vchFalse(0);
-    static const valtype vchZero(0);
+    // static const valtype vchZero(0);
     static const valtype vchTrue(1, 1);
 
     CScript::const_iterator pc = script.begin();
diff --git a/src/wallet/db.cpp b/src/wallet/db.cpp
@@ -466,15 +466,6 @@ void CDBEnv::CloseDb(const std::string& strFile)
     }
 }
 
-bool CDBEnv::RemoveDb(const std::string& strFile)
-{
-    this->CloseDb(strFile);
-
-    LOCK(cs_db);
-    int rc = dbenv->dbremove(NULL, strFile.c_str(), NULL, DB_AUTO_COMMIT);
-    return (rc == 0);
-}
-
 bool CDB::Rewrite(CWalletDBWrapper& dbw, const char* pszSkip)
 {
     if (dbw.IsDummy()) {
diff --git a/src/wallet/db.h b/src/wallet/db.h
@@ -72,7 +72,6 @@ class CDBEnv
     void CheckpointLSN(const std::string& strFile);
 
     void CloseDb(const std::string& strFile);
-    bool RemoveDb(const std::string& strFile);
 
     DbTxn* TxnBegin(int flags = DB_TXN_WRITE_NOSYNC)
     {

Original file line number	Diff line number	Diff line change
`@@ -103,8 +103,3 @@ std::string ChainNameFromCommandLine()`
`103`	`103`	`return CBaseChainParams::TESTNET;`
`104`	`104`	`return CBaseChainParams::MAIN;`
`105`	`105`	`}`
`106`		`-`
`107`		`-bool AreBaseParamsConfigured()`
`108`		`-{`
`109`		`- return pCurrentBaseParams != NULL;`
`110`		`-}`
Original file line number	Diff line number	Diff line change
`@@ -179,12 +179,6 @@ bool CNetAddr::IsLocal() const`
`179`	`179`	`return false;`
`180`	`180`	`}`
`181`	`181`
`182`		`-bool CNetAddr::IsMulticast() const`
`183`		`-{`
`184`		`- return (IsIPv4() && (GetByte(3) & 0xF0) == 0xE0)`
`185`		`- \|\| (GetByte(15) == 0xFF);`
`186`		`-}`
`187`		`-`
`188`	`182`	`bool CNetAddr::IsValid() const`
`189`	`183`	`{`
`190`	`184`	`// Cleanup 3-byte shifted addresses caused by garbage in size field`
Original file line number	Diff line number	Diff line change
`@@ -466,15 +466,6 @@ void CDBEnv::CloseDb(const std::string& strFile)`
`466`	`466`	`}`
`467`	`467`	`}`
`468`	`468`
`469`		`-bool CDBEnv::RemoveDb(const std::string& strFile)`
`470`		`-{`
`471`		`- this->CloseDb(strFile);`
`472`		`-`
`473`		`- LOCK(cs_db);`
`474`		`- int rc = dbenv->dbremove(NULL, strFile.c_str(), NULL, DB_AUTO_COMMIT);`
`475`		`- return (rc == 0);`
`476`		`-}`
`477`		`-`
`478`	`469`	`bool CDB::Rewrite(CWalletDBWrapper& dbw, const char* pszSkip)`
`479`	`470`	`{`
`480`	`471`	`if (dbw.IsDummy()) {`
Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,6 @@ class CDBEnv`
`72`	`72`	`void CheckpointLSN(const std::string& strFile);`
`73`	`73`
`74`	`74`	`void CloseDb(const std::string& strFile);`
`75`		`- bool RemoveDb(const std::string& strFile);`
`76`	`75`
`77`	`76`	`DbTxn* TxnBegin(int flags = DB_TXN_WRITE_NOSYNC)`
`78`	`77`	`{`