Don't throw in GetTime{Millis,Micros}(). Mark as noexcept.

practicalswift · practicalswift · commit afc97c731e40 · 2018-11-05T13:51:39.000+01:00
diff --git a/src/util/time.cpp b/src/util/time.cpp
@@ -37,18 +37,20 @@ int64_t GetMockTime()
     return nMockTime.load(std::memory_order_relaxed);
 }
 
-int64_t GetTimeMillis()
+int64_t GetTimeMillis() noexcept
 {
+    static const boost::posix_time::ptime epoch = boost::posix_time::from_time_t(0);
     int64_t now = (boost::posix_time::microsec_clock::universal_time() -
-                   boost::posix_time::ptime(boost::gregorian::date(1970,1,1))).total_milliseconds();
+                   epoch).total_milliseconds();
     assert(now > 0);
     return now;
 }
 
-int64_t GetTimeMicros()
+int64_t GetTimeMicros() noexcept
 {
+    static const boost::posix_time::ptime epoch = boost::posix_time::from_time_t(0);
     int64_t now = (boost::posix_time::microsec_clock::universal_time() -
-                   boost::posix_time::ptime(boost::gregorian::date(1970,1,1))).total_microseconds();
+                   epoch).total_microseconds();
     assert(now > 0);
     return now;
 }
diff --git a/src/util/time.h b/src/util/time.h
@@ -20,8 +20,8 @@
  */
 
 int64_t GetTime();
-int64_t GetTimeMillis();
-int64_t GetTimeMicros();
+int64_t GetTimeMillis() noexcept;
+int64_t GetTimeMicros() noexcept;
 int64_t GetSystemTimeInSeconds(); // Like GetTime(), but not mockable
 void SetMockTime(int64_t nMockTimeIn);
 int64_t GetMockTime();

Original file line number	Diff line number	Diff line change
`@@ -37,18 +37,20 @@ int64_t GetMockTime()`
`37`	`37`	`return nMockTime.load(std::memory_order_relaxed);`
`38`	`38`	`}`
`39`	`39`
`40`		`-int64_t GetTimeMillis()`
	`40`	`+int64_t GetTimeMillis() noexcept`
`41`	`41`	`{`
	`42`	`+ static const boost::posix_time::ptime epoch = boost::posix_time::from_time_t(0);`
`42`	`43`	`int64_t now = (boost::posix_time::microsec_clock::universal_time() -`
`43`		`- boost::posix_time::ptime(boost::gregorian::date(1970,1,1))).total_milliseconds();`
	`44`	`+ epoch).total_milliseconds();`
`44`	`45`	`assert(now > 0);`
`45`	`46`	`return now;`
`46`	`47`	`}`
`47`	`48`
`48`		`-int64_t GetTimeMicros()`
	`49`	`+int64_t GetTimeMicros() noexcept`
`49`	`50`	`{`
	`51`	`+ static const boost::posix_time::ptime epoch = boost::posix_time::from_time_t(0);`
`50`	`52`	`int64_t now = (boost::posix_time::microsec_clock::universal_time() -`
`51`		`- boost::posix_time::ptime(boost::gregorian::date(1970,1,1))).total_microseconds();`
	`53`	`+ epoch).total_microseconds();`
`52`	`54`	`assert(now > 0);`
`53`	`55`	`return now;`
`54`	`56`	`}`