qa: Replace always-escaped regexps with "X in Y"

hodlinator · l0rinc · hodlinator · commit a9021101dc63 · 2025-09-26T22:27:42.000+02:00
Always escaping the search string makes the use of regular expressions unnecessary.

Co-authored-by: Lőrinc &lt;pap.lorinc@gmail.com&gt;
diff --git a/test/functional/test_framework/test_node.py b/test/functional/test_framework/test_node.py
@@ -559,10 +559,10 @@ def assert_debug_log(self, expected_msgs, unexpected_msgs=None, timeout=2):
                 log = dl.read()
             print_log = " - " + "\n - ".join(log.splitlines())
             for unexpected_msg in unexpected_msgs:
-                if re.search(re.escape(unexpected_msg), log, flags=re.MULTILINE):
+                if unexpected_msg in log:
                     self._raise_assertion_error('Unexpected message "{}" partially matches log:\n\n{}\n\n'.format(unexpected_msg, print_log))
             for expected_msg in expected_msgs:
-                if re.search(re.escape(expected_msg), log, flags=re.MULTILINE) is None:
+                if expected_msg not in log:
                     found = False
             if found:
                 return
