added asserts to check m_addr_known when it's used

naumenkogs · naumenkogs · commit a552e8477c5b · 2019-10-25T16:28:14.000-04:00
diff --git a/src/net.h b/src/net.h
@@ -884,6 +884,7 @@ class CNode
 
     void AddAddressKnown(const CAddress& _addr)
     {
+        assert(m_addr_known);
         m_addr_known->insert(_addr.GetKey());
     }
 
@@ -892,6 +893,7 @@ class CNode
         // Known checking here is only to save space from duplicates.
         // SendMessages will filter it again for knowns that were added
         // after addresses were pushed.
+        assert(m_addr_known);
         if (_addr.IsValid() && !m_addr_known->contains(_addr.GetKey())) {
             if (vAddrToSend.size() >= MAX_ADDR_TO_SEND) {
                 vAddrToSend[insecure_rand.randrange(vAddrToSend.size())] = _addr;
diff --git a/src/net_processing.cpp b/src/net_processing.cpp
@@ -3561,6 +3561,7 @@ bool PeerLogicValidation::SendMessages(CNode* pto)
             pto->nNextAddrSend = PoissonNextSend(nNow, AVG_ADDRESS_BROADCAST_INTERVAL);
             std::vector<CAddress> vAddr;
             vAddr.reserve(pto->vAddrToSend.size());
+            assert(pto->m_addr_known);
             for (const CAddress& addr : pto->vAddrToSend)
             {
                 if (!pto->m_addr_known->contains(addr.GetKey()))

Original file line number	Diff line number	Diff line change
`@@ -884,6 +884,7 @@ class CNode`
`884`	`884`
`885`	`885`	`void AddAddressKnown(const CAddress& _addr)`
`886`	`886`	`{`
	`887`	`+ assert(m_addr_known);`
`887`	`888`	`m_addr_known->insert(_addr.GetKey());`
`888`	`889`	`}`
`889`	`890`
`@@ -892,6 +893,7 @@ class CNode`
`892`	`893`	`// Known checking here is only to save space from duplicates.`
`893`	`894`	`// SendMessages will filter it again for knowns that were added`
`894`	`895`	`// after addresses were pushed.`
	`896`	`+ assert(m_addr_known);`
`895`	`897`	`if (_addr.IsValid() && !m_addr_known->contains(_addr.GetKey())) {`
`896`	`898`	`if (vAddrToSend.size() >= MAX_ADDR_TO_SEND) {`
`897`	`899`	`vAddrToSend[insecure_rand.randrange(vAddrToSend.size())] = _addr;`
Original file line number	Diff line number	Diff line change
`@@ -3561,6 +3561,7 @@ bool PeerLogicValidation::SendMessages(CNode* pto)`
`3561`	`3561`	`pto->nNextAddrSend = PoissonNextSend(nNow, AVG_ADDRESS_BROADCAST_INTERVAL);`
`3562`	`3562`	`std::vector<CAddress> vAddr;`
`3563`	`3563`	`vAddr.reserve(pto->vAddrToSend.size());`
	`3564`	`+ assert(pto->m_addr_known);`
`3564`	`3565`	`for (const CAddress& addr : pto->vAddrToSend)`
`3565`	`3566`	`{`
`3566`	`3567`	`if (!pto->m_addr_known->contains(addr.GetKey()))`