SetMerkleBranch: remove unused code, remove cs_main lock requirement

jonasschnelli · jonasschnelli · commit 9e351c9586ef · 2016-12-30T10:37:13.000+01:00
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -3736,21 +3736,13 @@ CWalletKey::CWalletKey(int64_t nExpires)
     nTimeExpires = nExpires;
 }
 
-int CMerkleTx::SetMerkleBranch(const CBlockIndex* pindex, int posInBlock)
+void CMerkleTx::SetMerkleBranch(const CBlockIndex* pindex, int posInBlock)
 {
-    AssertLockHeld(cs_main);
-
     // Update the tx's hashBlock
     hashBlock = pindex->GetBlockHash();
 
     // set the position of the transaction in the block
     nIndex = posInBlock;
-
-    // Is the tx in a block that's in the main chain
-    if (!chainActive.Contains(pindex))
-        return 0;
-
-    return chainActive.Height() - pindex->nHeight + 1;
 }
 
 int CMerkleTx::GetDepthInMainChain(const CBlockIndex* &pindexRet) const
diff --git a/src/wallet/wallet.h b/src/wallet/wallet.h
@@ -218,7 +218,7 @@ class CMerkleTx
         READWRITE(nIndex);
     }
 
-    int SetMerkleBranch(const CBlockIndex* pIndex, int posInBlock);
+    void SetMerkleBranch(const CBlockIndex* pIndex, int posInBlock);
 
     /**
      * Return depth of transaction in blockchain:

Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,7 @@ class CMerkleTx`
`218`	`218`	`READWRITE(nIndex);`
`219`	`219`	`}`
`220`	`220`
`221`		`- int SetMerkleBranch(const CBlockIndex* pIndex, int posInBlock);`
	`221`	`+ void SetMerkleBranch(const CBlockIndex* pIndex, int posInBlock);`
`222`	`222`
`223`	`223`	`/**`
`224`	`224`	`* Return depth of transaction in blockchain:`