lint: Add linter to error on #include <*.cpp>

Empact · Empact · commit 9d6c9dbb8859 · 2018-06-06T02:11:25.000-07:00
Files should depend on one another by interface, not by implementation.
This checks for quoted includes as well.

With practicalswift
diff --git a/test/lint/lint-includes.sh b/test/lint/lint-includes.sh
@@ -33,6 +33,14 @@ for CPP_FILE in $(filter_suffix cpp); do
     fi
 done
 
+INCLUDED_CPP_FILES=$(git grep -E "^#include [<\"][^>\"]+\.cpp[>\"]" -- "*.cpp" "*.h")
+if [[ ${INCLUDED_CPP_FILES} != "" ]]; then
+    echo "The following files #include .cpp files:"
+    echo "${INCLUDED_CPP_FILES}"
+    echo
+    EXIT_CODE=1
+fi
+
 EXPECTED_BOOST_INCLUDES=(
     boost/algorithm/string.hpp
     boost/algorithm/string/case_conv.hpp
