RPC/rawtransaction: createrawtransaction: Check opt_into_rbf when provided with either value

luke-jr · luke-jr · commit 9a5a1d7d452e · 2017-06-05T23:14:34.000Z
diff --git a/src/Makefile.am b/src/Makefile.am
@@ -198,6 +198,7 @@ libbitcoin_server_a_SOURCES = \
   noui.cpp \
   policy/fees.cpp \
   policy/policy.cpp \
+  policy/rbf.cpp \
   pow.cpp \
   rest.cpp \
   rpc/blockchain.cpp \
@@ -240,7 +241,6 @@ libbitcoin_wallet_a_SOURCES = \
   wallet/rpcwallet.cpp \
   wallet/wallet.cpp \
   wallet/walletdb.cpp \
-  policy/rbf.cpp \
   $(BITCOIN_CORE_H)
 
 # crypto primitives library
diff --git a/src/rpc/rawtransaction.cpp b/src/rpc/rawtransaction.cpp
@@ -316,7 +316,7 @@ UniValue createrawtransaction(const JSONRPCRequest& request)
             "      ,...\n"
             "    }\n"
             "3. locktime                  (numeric, optional, default=0) Raw locktime. Non-0 value also locktime-activates inputs\n"
-            "4. optintorbf                (boolean, optional, default=false) Allow this transaction to be replaced by a transaction with higher fees\n"
+            "4. optintorbf                (boolean, optional, default=false) Allow this transaction to be replaced by a transaction with higher fees. If provided, it is an error if explicit sequence numbers are incompatible.\n"
             "\nResult:\n"
             "\"transaction\"              (string) hex string of the transaction\n"
 
@@ -373,8 +373,6 @@ UniValue createrawtransaction(const JSONRPCRequest& request)
             int64_t seqNr64 = sequenceObj.get_int64();
             if (seqNr64 < 0 || seqNr64 > std::numeric_limits<uint32_t>::max()) {
                 throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, sequence number is out of range");
-            } else if (seqNr64 <= MAX_BIP125_RBF_SEQUENCE && request.params.size() > 3 && request.params[3].isFalse()) {
-                throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter combination: Sequence number contradicts optintorbf option");
             } else {
                 nSequence = (uint32_t)seqNr64;
             }
@@ -411,6 +409,10 @@ UniValue createrawtransaction(const JSONRPCRequest& request)
         }
     }
 
+    if (request.params.size() > 3 && rbfOptIn != SignalsOptInRBF(rawTx)) {
+        throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter combination: Sequence number(s) contradict optintorbf option");
+    }
+
     return EncodeHexTx(rawTx);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -316,7 +316,7 @@ UniValue createrawtransaction(const JSONRPCRequest& request)`
`316`	`316`	`" ,...\n"`
`317`	`317`	`" }\n"`
`318`	`318`	`"3. locktime (numeric, optional, default=0) Raw locktime. Non-0 value also locktime-activates inputs\n"`
`319`		`- "4. optintorbf (boolean, optional, default=false) Allow this transaction to be replaced by a transaction with higher fees\n"`
	`319`	`+ "4. optintorbf (boolean, optional, default=false) Allow this transaction to be replaced by a transaction with higher fees. If provided, it is an error if explicit sequence numbers are incompatible.\n"`
`320`	`320`	`"\nResult:\n"`
`321`	`321`	`"\"transaction\" (string) hex string of the transaction\n"`
`322`	`322`
`@@ -373,8 +373,6 @@ UniValue createrawtransaction(const JSONRPCRequest& request)`
`373`	`373`	`int64_t seqNr64 = sequenceObj.get_int64();`
`374`	`374`	`if (seqNr64 < 0 \|\| seqNr64 > std::numeric_limits<uint32_t>::max()) {`
`375`	`375`	`throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, sequence number is out of range");`
`376`		`- } else if (seqNr64 <= MAX_BIP125_RBF_SEQUENCE && request.params.size() > 3 && request.params[3].isFalse()) {`
`377`		`- throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter combination: Sequence number contradicts optintorbf option");`
`378`	`376`	`} else {`
`379`	`377`	`nSequence = (uint32_t)seqNr64;`
`380`	`378`	`}`
`@@ -411,6 +409,10 @@ UniValue createrawtransaction(const JSONRPCRequest& request)`
`411`	`409`	`}`
`412`	`410`	`}`
`413`	`411`
	`412`	`+ if (request.params.size() > 3 && rbfOptIn != SignalsOptInRBF(rawTx)) {`
	`413`	`+ throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter combination: Sequence number(s) contradict optintorbf option");`
	`414`	`+ }`
	`415`	`+`
`414`	`416`	`return EncodeHexTx(rawTx);`
`415`	`417`	`}`
`416`	`418`