[refactor] use waiting inside disconnect_p2ps

glozow · glozow · commit 9a40cfc558b3 · 2020-06-16T08:28:55.000-07:00
-Use wait_for_disconnect instead of manual
wait after calling disconnect_p2ps.
diff --git a/test/functional/p2p_leak.py b/test/functional/p2p_leak.py
@@ -132,9 +132,6 @@ def run_test(self):
 
         self.nodes[0].disconnect_p2ps()
 
-        # Wait until all connections are closed
-        wait_until(lambda: len(self.nodes[0].getpeerinfo()) == 0)
-
         # Make sure no unexpected messages came in
         assert no_version_bannode.unexpected_msg == False
         assert no_version_idlenode.unexpected_msg == False
diff --git a/test/functional/p2p_node_network_limited.py b/test/functional/p2p_node_network_limited.py
@@ -83,7 +83,6 @@ def run_test(self):
         assert_equal(node1.firstAddrnServices, expected_services)
 
         self.nodes[0].disconnect_p2ps()
-        node1.wait_for_disconnect()
 
         # connect unsynced node 2 with pruned NODE_NETWORK_LIMITED peer
         # because node 2 is in IBD and node 0 is a NODE_NETWORK_LIMITED peer, sync must not be possible
