refactor: encapsulate flags get access for all other checks

andrewtoth · andrewtoth · commit 9715d3bf1e40 · 2024-08-01T23:36:00.000-04:00
No behavior change. This prepares moving the cache entry
flags field to private access.
diff --git a/src/coins.h b/src/coins.h
@@ -131,6 +131,7 @@ struct CCoinsCacheEntry
     explicit CCoinsCacheEntry(Coin&& coin_) : coin(std::move(coin_)), flags(0) {}
     CCoinsCacheEntry(Coin&& coin_, unsigned char flag) : coin(std::move(coin_)), flags(flag) {}
 
+    inline unsigned char GetFlags() const noexcept { return flags; }
     inline bool IsDirty() const noexcept { return flags & DIRTY; }
     inline bool IsFresh() const noexcept { return flags & FRESH; }
 };
diff --git a/src/test/coins_tests.cpp b/src/test/coins_tests.cpp
@@ -603,7 +603,7 @@ void GetCoinsMapEntry(const CCoinsMap& map, CAmount& value, char& flags, const C
         } else {
             value = it->second.coin.out.nValue;
         }
-        flags = it->second.flags;
+        flags = it->second.GetFlags();
         assert(flags != NO_ENTRY);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -603,7 +603,7 @@ void GetCoinsMapEntry(const CCoinsMap& map, CAmount& value, char& flags, const C`
`603`	`603`	`} else {`
`604`	`604`	`value = it->second.coin.out.nValue;`
`605`	`605`	`}`
`606`		`- flags = it->second.flags;`
	`606`	`+ flags = it->second.GetFlags();`
`607`	`607`	`assert(flags != NO_ENTRY);`
`608`	`608`	`}`
`609`	`609`	`}`