Merge #19194: util: Don't reference errno when pthread fails.

fanquake · fanquake · commit 9573d2b55b45 · 2020-06-08T19:36:28.000+08:00
cb38b06 util: Don't reference errno when pthread fails. (MIZUTA Takeshi) Pull request description: Pthread library does not set errno. Pthread library's errno is returned by return value. ACKs for top commit: practicalswift: ACK cb38b06 -- patch looks correct MarcoFalke: review ACK cb38b06 hebasto: ACK cb38b06, only squashed commits since the [previous](#19194 (review)) review. Tree-SHA512: e6c950e30726e5031db97a7b84c8a9215da5ad3e5d233bcc349f812ad15957ddfe378e26d18339b9e0a5dcac2f50b47a687b87a6a6beaf6139df84f31531321e
diff --git a/src/util/system.cpp b/src/util/system.cpp
@@ -1163,8 +1163,9 @@ void ScheduleBatchPriority()
 {
 #ifdef SCHED_BATCH
     const static sched_param param{};
-    if (pthread_setschedparam(pthread_self(), SCHED_BATCH, &param) != 0) {
-        LogPrintf("Failed to pthread_setschedparam: %s\n", strerror(errno));
+    const int rc = pthread_setschedparam(pthread_self(), SCHED_BATCH, &param);
+    if (rc != 0) {
+        LogPrintf("Failed to pthread_setschedparam: %s\n", strerror(rc));
     }
 #endif
 }

Original file line number	Diff line number	Diff line change
`@@ -1163,8 +1163,9 @@ void ScheduleBatchPriority()`
`1163`	`1163`	`{`
`1164`	`1164`	`#ifdef SCHED_BATCH`
`1165`	`1165`	`const static sched_param param{};`
`1166`		`- if (pthread_setschedparam(pthread_self(), SCHED_BATCH, &param) != 0) {`
`1167`		`- LogPrintf("Failed to pthread_setschedparam: %s\n", strerror(errno));`
	`1166`	`+ const int rc = pthread_setschedparam(pthread_self(), SCHED_BATCH, &param);`
	`1167`	`+ if (rc != 0) {`
	`1168`	`+ LogPrintf("Failed to pthread_setschedparam: %s\n", strerror(rc));`
`1168`	`1169`	`}`
`1169`	`1170`	`#endif`
`1170`	`1171`	`}`