util, refactor: Drop explicit conversion to fs::path

hebasto · hebasto · commit 92aacdabf9b6 · 2022-03-25T22:10:23.000+01:00
Removes unhelpful noise/verbosity. See: #24306 (comment)
diff --git a/src/util/system.cpp b/src/util/system.cpp
@@ -517,7 +517,7 @@ bool ArgsManager::InitSettings(std::string& error)
 
 bool ArgsManager::GetSettingsPath(fs::path* filepath, bool temp) const
 {
-    fs::path settings = GetPathArg("-settings", fs::path{BITCOIN_SETTINGS_FILENAME});
+    fs::path settings = GetPathArg("-settings", BITCOIN_SETTINGS_FILENAME);
     if (settings.empty()) {
         return false;
     }

Original file line number	Diff line number	Diff line change
`@@ -517,7 +517,7 @@ bool ArgsManager::InitSettings(std::string& error)`
`517`	`517`
`518`	`518`	`bool ArgsManager::GetSettingsPath(fs::path* filepath, bool temp) const`
`519`	`519`	`{`
`520`		`- fs::path settings = GetPathArg("-settings", fs::path{BITCOIN_SETTINGS_FILENAME});`
	`520`	`+ fs::path settings = GetPathArg("-settings", BITCOIN_SETTINGS_FILENAME);`
`521`	`521`	`if (settings.empty()) {`
`522`	`522`	`return false;`
`523`	`523`	`}`