fix CreateTransaction error messages

instagibbs · instagibbs · commit 918b126901d6 · 2016-11-22T13:40:57.000-05:00
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -2238,17 +2238,17 @@ bool CWallet::CreateTransaction(const vector<CRecipient>& vecSend, CWalletTx& wt
     {
         if (nValue < 0 || recipient.nAmount < 0)
         {
-            strFailReason = _("Transaction amounts must be positive");
+            strFailReason = _("Transaction amounts must not be negative");
             return false;
         }
         nValue += recipient.nAmount;
 
         if (recipient.fSubtractFeeFromAmount)
             nSubtractFeeFromAmount++;
     }
-    if (vecSend.empty() || nValue < 0)
+    if (vecSend.empty())
     {
-        strFailReason = _("Transaction amounts must be positive");
+        strFailReason = _("Transaction must have at least one recipient");
         return false;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -2238,17 +2238,17 @@ bool CWallet::CreateTransaction(const vector<CRecipient>& vecSend, CWalletTx& wt`
`2238`	`2238`	`{`
`2239`	`2239`	`if (nValue < 0 \|\| recipient.nAmount < 0)`
`2240`	`2240`	`{`
`2241`		`- strFailReason = _("Transaction amounts must be positive");`
	`2241`	`+ strFailReason = _("Transaction amounts must not be negative");`
`2242`	`2242`	`return false;`
`2243`	`2243`	`}`
`2244`	`2244`	`nValue += recipient.nAmount;`
`2245`	`2245`
`2246`	`2246`	`if (recipient.fSubtractFeeFromAmount)`
`2247`	`2247`	`nSubtractFeeFromAmount++;`
`2248`	`2248`	`}`
`2249`		`- if (vecSend.empty() \|\| nValue < 0)`
	`2249`	`+ if (vecSend.empty())`
`2250`	`2250`	`{`
`2251`		`- strFailReason = _("Transaction amounts must be positive");`
	`2251`	`+ strFailReason = _("Transaction must have at least one recipient");`
`2252`	`2252`	`return false;`
`2253`	`2253`	`}`
`2254`	`2254`