Skip to content

Commit 890ac25

Browse files
TheBlueMattlaanwj
authored andcommitted
Fix overly-prescriptive p2p-segwit test for new fetch logic
Github-Pull: #8393 Rebased-From: be7555f
1 parent fe1975a commit 890ac25

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

qa/rpc-tests/p2p-segwit.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -909,14 +909,6 @@ def test_witness_tx_relay_before_segwit_activation(self):
909909
# But eliminating the witness should fix it
910910
self.test_node.test_transaction_acceptance(tx, with_witness=False, accepted=True)
911911

912-
# Verify that inv's to test_node come with getdata's for non-witness tx's
913-
# Just tweak the transaction, announce it, and verify we get a getdata
914-
# for a normal tx
915-
tx.vout[0].scriptPubKey = CScript([OP_TRUE, OP_TRUE])
916-
tx.rehash()
917-
self.test_node.announce_tx_and_wait_for_getdata(tx)
918-
assert(self.test_node.last_getdata.inv[0].type == 1)
919-
920912
# Cleanup: mine the first transaction and update utxo
921913
self.nodes[0].generate(1)
922914
assert_equal(len(self.nodes[0].getrawmempool()), 0)
@@ -1022,7 +1014,7 @@ def test_tx_relay_after_segwit_activation(self):
10221014
def test_block_relay(self, segwit_activated):
10231015
print("\tTesting block relay")
10241016

1025-
blocktype = 2|MSG_WITNESS_FLAG if segwit_activated else 2
1017+
blocktype = 2|MSG_WITNESS_FLAG
10261018

10271019
# test_node has set NODE_WITNESS, so all getdata requests should be for
10281020
# witness blocks.

0 commit comments

Comments
 (0)