refactor: Replace use of atoi64 in wallet ReadOrderPos

laanwj · laanwj · commit 87a3f13dfeff · 2019-11-05T21:47:44.000+01:00
Replace use of `atoi64` with error-checking `ParseInt64`.
diff --git a/src/wallet/wallet.h b/src/wallet/wallet.h
@@ -200,12 +200,10 @@ typedef std::map<std::string, std::string> mapValue_t;
 
 static inline void ReadOrderPos(int64_t& nOrderPos, mapValue_t& mapValue)
 {
-    if (!mapValue.count("n"))
+    if (!mapValue.count("n") || !ParseInt64(mapValue["n"], &nOrderPos))
     {
         nOrderPos = -1; // TODO: calculate elsewhere
-        return;
     }
-    nOrderPos = atoi64(mapValue["n"].c_str());
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -200,12 +200,10 @@ typedef std::map<std::string, std::string> mapValue_t;`
`200`	`200`
`201`	`201`	`static inline void ReadOrderPos(int64_t& nOrderPos, mapValue_t& mapValue)`
`202`	`202`	`{`
`203`		`- if (!mapValue.count("n"))`
	`203`	`+ if (!mapValue.count("n") \|\| !ParseInt64(mapValue["n"], &nOrderPos))`
`204`	`204`	`{`
`205`	`205`	`nOrderPos = -1; // TODO: calculate elsewhere`
`206`		`- return;`
`207`	`206`	`}`
`208`		`- nOrderPos = atoi64(mapValue["n"].c_str());`
`209`	`207`	`}`
`210`	`208`
`211`	`209`