uint256: 1 is a constant

ajtowns · ajtowns · commit 832109af0d21 · 2020-09-25T15:01:38.000+10:00
diff --git a/src/uint256.cpp b/src/uint256.cpp
@@ -80,7 +80,7 @@ template std::string base_blob<256>::ToString() const;
 template void base_blob<256>::SetHex(const char*);
 template void base_blob<256>::SetHex(const std::string&);
 
-uint256& UINT256_ONE() {
-    static uint256* one = new uint256(uint256S("0000000000000000000000000000000000000000000000000000000000000001"));
+const uint256& UINT256_ONE() {
+    static const uint256* one = new uint256(uint256S("0000000000000000000000000000000000000000000000000000000000000001"));
     return *one;
 }
diff --git a/src/uint256.h b/src/uint256.h
@@ -147,6 +147,6 @@ inline uint256 uint256S(const std::string& str)
     return rv;
 }
 
-uint256& UINT256_ONE();
+const uint256& UINT256_ONE();
 
 #endif // BITCOIN_UINT256_H

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ template std::string base_blob<256>::ToString() const;`
`80`	`80`	`template void base_blob<256>::SetHex(const char*);`
`81`	`81`	`template void base_blob<256>::SetHex(const std::string&);`
`82`	`82`
`83`		`-uint256& UINT256_ONE() {`
`84`		`- static uint256* one = new uint256(uint256S("0000000000000000000000000000000000000000000000000000000000000001"));`
	`83`	`+const uint256& UINT256_ONE() {`
	`84`	`+ static const uint256* one = new uint256(uint256S("0000000000000000000000000000000000000000000000000000000000000001"));`
`85`	`85`	`return *one;`
`86`	`86`	`}`
Original file line number	Diff line number	Diff line change
`@@ -147,6 +147,6 @@ inline uint256 uint256S(const std::string& str)`
`147`	`147`	`return rv;`
`148`	`148`	`}`
`149`	`149`
`150`		`-uint256& UINT256_ONE();`
	`150`	`+const uint256& UINT256_ONE();`
`151`	`151`
`152`	`152`	`#endif // BITCOIN_UINT256_H`