refactor: replace RecursiveMutex m_most_recent_block_mutex with Mutex

theStack · theStack · commit 83003ffe049a · 2022-05-16T15:26:39.000+02:00
In each of the critical sections, only the the guarded variables are
accessed, without any chance that within one section another one is
called.  Hence, we can use an ordinary Mutex instead of RecursiveMutex.
diff --git a/src/net_processing.cpp b/src/net_processing.cpp
@@ -687,7 +687,7 @@ class PeerManagerImpl final : public PeerManager
 
 
     // All of the following cache a recent block, and are protected by m_most_recent_block_mutex
-    RecursiveMutex m_most_recent_block_mutex;
+    Mutex m_most_recent_block_mutex;
     std::shared_ptr<const CBlock> m_most_recent_block GUARDED_BY(m_most_recent_block_mutex);
     std::shared_ptr<const CBlockHeaderAndShortTxIDs> m_most_recent_compact_block GUARDED_BY(m_most_recent_block_mutex);
     uint256 m_most_recent_block_hash GUARDED_BY(m_most_recent_block_mutex);
