Generalize PublicOnlySigningProvider into HidingSigningProvider

sipa · sipa · commit 81e1dd5ce1a3 · 2018-08-13T08:46:23.000-07:00
diff --git a/src/script/sign.cpp b/src/script/sign.cpp
@@ -640,18 +640,25 @@ void PSBTOutput::Merge(const PSBTOutput& output)
     if (witness_script.empty() && !output.witness_script.empty()) witness_script = output.witness_script;
 }
 
-bool PublicOnlySigningProvider::GetCScript(const CScriptID &scriptid, CScript& script) const
+bool HidingSigningProvider::GetCScript(const CScriptID& scriptid, CScript& script) const
 {
     return m_provider->GetCScript(scriptid, script);
 }
 
-bool PublicOnlySigningProvider::GetPubKey(const CKeyID& keyid, CPubKey& pubkey) const
+bool HidingSigningProvider::GetPubKey(const CKeyID& keyid, CPubKey& pubkey) const
 {
     return m_provider->GetPubKey(keyid, pubkey);
 }
 
-bool PublicOnlySigningProvider::GetKeyOrigin(const CKeyID& keyid, KeyOriginInfo& info) const
+bool HidingSigningProvider::GetKey(const CKeyID& keyid, CKey& key) const
 {
+    if (m_hide_secret) return false;
+    return m_provider->GetKey(keyid, key);
+}
+
+bool HidingSigningProvider::GetKeyOrigin(const CKeyID& keyid, KeyOriginInfo& info) const
+{
+    if (m_hide_origin) return false;
     return m_provider->GetKeyOrigin(keyid, info);
 }
 
diff --git a/src/script/sign.h b/src/script/sign.h
@@ -39,16 +39,19 @@ class SigningProvider
 
 extern const SigningProvider& DUMMY_SIGNING_PROVIDER;
 
-class PublicOnlySigningProvider : public SigningProvider
+class HidingSigningProvider : public SigningProvider
 {
 private:
+    const bool m_hide_secret;
+    const bool m_hide_origin;
     const SigningProvider* m_provider;
 
 public:
-    PublicOnlySigningProvider(const SigningProvider* provider) : m_provider(provider) {}
-    bool GetCScript(const CScriptID &scriptid, CScript& script) const;
-    bool GetPubKey(const CKeyID &address, CPubKey& pubkey) const;
-    bool GetKeyOrigin(const CKeyID& keyid, KeyOriginInfo& info) const;
+    HidingSigningProvider(const SigningProvider* provider, bool hide_secret, bool hide_origin) : m_hide_secret(hide_secret), m_hide_origin(hide_origin), m_provider(provider) {}
+    bool GetCScript(const CScriptID& scriptid, CScript& script) const override;
+    bool GetPubKey(const CKeyID& keyid, CPubKey& pubkey) const override;
+    bool GetKey(const CKeyID& keyid, CKey& key) const override;
+    bool GetKeyOrigin(const CKeyID& keyid, KeyOriginInfo& info) const override;
 };
 
 struct FlatSigningProvider final : public SigningProvider
diff --git a/src/wallet/rpcwallet.cpp b/src/wallet/rpcwallet.cpp
@@ -4520,11 +4520,7 @@ bool FillPSBT(const CWallet* pwallet, PartiallySignedTransaction& psbtx, const C
         }
 
         SignatureData sigdata;
-        if (sign) {
-            complete &= SignPSBTInput(*pwallet, *psbtx.tx, input, sigdata, i, sighash_type);
-        } else {
-            complete &= SignPSBTInput(PublicOnlySigningProvider(pwallet), *psbtx.tx, input, sigdata, i, sighash_type);
-        }
+        complete &= SignPSBTInput(HidingSigningProvider(pwallet, !sign, false), *psbtx.tx, input, sigdata, i, sighash_type);
 
         if (it != pwallet->mapWallet.end()) {
             // Drop the unnecessary UTXO if we added both from the wallet.

Original file line number	Diff line number	Diff line change
`@@ -640,18 +640,25 @@ void PSBTOutput::Merge(const PSBTOutput& output)`
`640`	`640`	`if (witness_script.empty() && !output.witness_script.empty()) witness_script = output.witness_script;`
`641`	`641`	`}`
`642`	`642`
`643`		`-bool PublicOnlySigningProvider::GetCScript(const CScriptID &scriptid, CScript& script) const`
	`643`	`+bool HidingSigningProvider::GetCScript(const CScriptID& scriptid, CScript& script) const`
`644`	`644`	`{`
`645`	`645`	`return m_provider->GetCScript(scriptid, script);`
`646`	`646`	`}`
`647`	`647`
`648`		`-bool PublicOnlySigningProvider::GetPubKey(const CKeyID& keyid, CPubKey& pubkey) const`
	`648`	`+bool HidingSigningProvider::GetPubKey(const CKeyID& keyid, CPubKey& pubkey) const`
`649`	`649`	`{`
`650`	`650`	`return m_provider->GetPubKey(keyid, pubkey);`
`651`	`651`	`}`
`652`	`652`
`653`		`-bool PublicOnlySigningProvider::GetKeyOrigin(const CKeyID& keyid, KeyOriginInfo& info) const`
	`653`	`+bool HidingSigningProvider::GetKey(const CKeyID& keyid, CKey& key) const`
`654`	`654`	`{`
	`655`	`+ if (m_hide_secret) return false;`
	`656`	`+ return m_provider->GetKey(keyid, key);`
	`657`	`+}`
	`658`	`+`
	`659`	`+bool HidingSigningProvider::GetKeyOrigin(const CKeyID& keyid, KeyOriginInfo& info) const`
	`660`	`+{`
	`661`	`+ if (m_hide_origin) return false;`
`655`	`662`	`return m_provider->GetKeyOrigin(keyid, info);`
`656`	`663`	`}`
`657`	`664`