Merge #14450: qt: Fix QCompleter popup regression

jonasschnelli · jonasschnelli · commit 816fab9ccae5 · 2018-10-17T20:25:35.000+02:00
081cc02 Fix QCompleter popup regression (Hennadii Stepanov) Pull request description: The PR #8129 has introduced a regression with the `QCompleter` popup in the Debug window. How to reproduce: 1. open the Debug window; 2. go to the 'Console' tab; 3. start writing some RPC command and try to pick it from the list using arrow keys, press Enter. Note that the popup used to display completions is not being closed. To close it they should mouse click somewhere outside of the popup. The wrong behaviour of the `QCompleter` popup is observed on Linux Mint 19 and Windows 10. This PR fixes this regression. Refs: - #7613 - #7772 - #8129 Tree-SHA512: f3ba8d08e1c07619d4ef307544306b57be43e4e726770976cf0c2af95082bd66e2eefe8aabb9a3fad0601cd9e6e4dea0459b6a63eba512023234feb308484655
diff --git a/src/qt/rpcconsole.cpp b/src/qt/rpcconsole.cpp
@@ -536,6 +536,7 @@ bool RPCConsole::eventFilter(QObject* obj, QEvent *event)
             // forward these events to lineEdit
             if(obj == autoCompleter->popup()) {
                 QApplication::postEvent(ui->lineEdit, new QKeyEvent(*keyevt));
+                autoCompleter->popup()->hide();
                 return true;
             }
             break;

Original file line number	Diff line number	Diff line change
`@@ -536,6 +536,7 @@ bool RPCConsole::eventFilter(QObject* obj, QEvent *event)`
`536`	`536`	`// forward these events to lineEdit`
`537`	`537`	`if(obj == autoCompleter->popup()) {`
`538`	`538`	`QApplication::postEvent(ui->lineEdit, new QKeyEvent(*keyevt));`
	`539`	`+ autoCompleter->popup()->hide();`
`539`	`540`	`return true;`
`540`	`541`	`}`
`541`	`542`	`break;`